Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Unified Diff: tools/dom/templates/html/impl/impl_Window.darttemplate

Issue 1540333002: Allow Window.open to return null in dart2js (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: ... and regenerate aftef fixing Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sdk/lib/html/dart2js/html_dart2js.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/dom/templates/html/impl/impl_Window.darttemplate
diff --git a/tools/dom/templates/html/impl/impl_Window.darttemplate b/tools/dom/templates/html/impl/impl_Window.darttemplate
index 896e2040bcd084c7d7adfbb7e1333d10a925cf75..d891762e968cf8a5c55c2ad3f3a1b4ae2cef12aa 100644
--- a/tools/dom/templates/html/impl/impl_Window.darttemplate
+++ b/tools/dom/templates/html/impl/impl_Window.darttemplate
@@ -47,10 +47,11 @@ $if DART2JS
*/
Document get document => JS('Document', '#.document', this);
- WindowBase _open2(url, name) => JS('Window', '#.open(#,#)', this, url, name);
+ WindowBase _open2(url, name) =>
+ JS('Window|Null', '#.open(#,#)', this, url, name);
WindowBase _open3(url, name, options) =>
- JS('Window', '#.open(#,#,#)', this, url, name, options);
+ JS('Window|Null', '#.open(#,#,#)', this, url, name, options);
/**
* Opens a new window.
« no previous file with comments | « sdk/lib/html/dart2js/html_dart2js.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698