MediaRecorder: update to spec (3/3)

third_party/WebKit/Source/modules/mediarecorder/MediaRecorder.cpp

Index: third_party/WebKit/Source/modules/mediarecorder/MediaRecorder.cpp
diff --git a/third_party/WebKit/Source/modules/mediarecorder/MediaRecorder.cpp b/third_party/WebKit/Source/modules/mediarecorder/MediaRecorder.cpp
index a5fba4558ef597488ec8b5f262c41a2e4dfe8b57..3871b0d0eb82a988359e85f7e0887ba33624fb64 100644
--- a/third_party/WebKit/Source/modules/mediarecorder/MediaRecorder.cpp
+++ b/third_party/WebKit/Source/modules/mediarecorder/MediaRecorder.cpp
@@ -6,12 +6,10 @@
 #include "modules/mediarecorder/MediaRecorder.h"
 
 #include "bindings/core/v8/Dictionary.h"
-#include "core/dom/DOMError.h"
+#include "core/events/Event.h"
 #include "core/fileapi/Blob.h"
-#include "modules/EventModules.h"
 #include "modules/EventTargetModules.h"
 #include "modules/mediarecorder/BlobEvent.h"
-#include "modules/mediarecorder/MediaRecorderErrorEvent.h"
 #include "platform/ContentType.h"
 #include "platform/NotImplemented.h"
 #include "platform/blob/BlobData.h"
@@ -226,8 +224,7 @@ void MediaRecorder::writeData(const char* data, size_t length, bool lastInSlice)
 
 void MediaRecorder::failOutOfMemory(const WebString& message)

[Peter Beverloo, 2015/12/22 11:59:35]

A few thoughts:

  (1) I think it's unfortunate that we're losing the error messages, this
reduces clarity. But if this improves alignment with the other media drafts, ok.
  (2) The MediaRecorder::fail*() methods actually aren't being called by our
implementation. Do you plan to call them?
  (3) The three MediaRecorder::fail*() methods are now identical. Can we unify
them into a single implementation?

I'm confused about ErrorEvent - there seem to be two? Let me reply to the GitHub
issue on that note.

[mcasas, 2015/12/22 20:24:40]

It is, I filed corresponding issues to track this situation:
https://github.com/w3c/mediacapture-record/issues/42
and
https://github.com/w3c/mediacapture-main/issues/298
Yes, there's a parallel CL calling fallingIllegalStreamModification()
when there's a Track added or removed, see https://crrev.com/1543673002
We should! Let me do that.

 {
-    scheduleDispatchEvent(MediaRecorderErrorEvent::create(
-        EventTypeNames::error, false, false, "OutOfMemory", message));
+    scheduleDispatchEvent(Event::create(EventTypeNames::error));
 
     if (m_state == State::Recording)
         stopRecording();
@@ -235,8 +232,7 @@ void MediaRecorder::failOutOfMemory(const WebString& message)
 
 void MediaRecorder::failIllegalStreamModification(const WebString& message)
 {
-    scheduleDispatchEvent(MediaRecorderErrorEvent::create(
-        EventTypeNames::error, false, false, "IllegalStreamModification", message));
+    scheduleDispatchEvent(Event::create(EventTypeNames::error));
 
     if (m_state == State::Recording)
         stopRecording();
@@ -244,8 +240,7 @@ void MediaRecorder::failIllegalStreamModification(const WebString& message)
 
 void MediaRecorder::failOtherRecordingError(const WebString& message)
 {
-    scheduleDispatchEvent(MediaRecorderErrorEvent::create(
-        EventTypeNames::error, false, false, "OtherRecordingError", message));
+    scheduleDispatchEvent(Event::create(EventTypeNames::error));
 
     if (m_state == State::Recording)
         stopRecording();