third_party/WebKit/Source/modules/mediarecorder/MediaRecorderOptions.idl - Issue 1540303003: MediaRecorder: update to spec (3/3)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/mediarecorder/MediaRecorderOptions.idl

Issue 1540303003: MediaRecorder: update to spec (3/3) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/modules/mediarecorder/MediaRecorder.cpp ('K') | « third_party/WebKit/Source/modules/mediarecorder/MediaRecorderErrorEvent.idl ('k') | third_party/WebKit/Source/modules/modules.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/mediarecorder/MediaRecorderOptions.idl

diff --git a/third_party/WebKit/Source/modules/mediarecorder/MediaRecorderOptions.idl b/third_party/WebKit/Source/modules/mediarecorder/MediaRecorderOptions.idl

index 1926fa01749d0c20df9c9947fa7c22ad4176853b..e325a305ba91fe86b852d15126abfbeae4e7ea5d 100644

--- a/third_party/WebKit/Source/modules/mediarecorder/MediaRecorderOptions.idl

+++ b/third_party/WebKit/Source/modules/mediarecorder/MediaRecorderOptions.idl

@@ -5,8 +5,7 @@

// https://w3c.github.io/mediacapture-record/MediaRecorder.html#MediaRecorderOptions

dictionary MediaRecorderOptions {

- // TODO(mcasas): remove "mime" prefix, https://github.com/w3c/mediacapture-record/issues/10

- DOMString mimeType = ""; // Default encoding mimeType.

+ DOMString mimeType; // Encoding mimeType.

Peter Beverloo 2015/12/22 11:59:35 micro nit, and sorry for not spotting this earlier

mcasas 2015/12/22 20:24:40 Done.

// TODO(mcasas): Include here the remaining spec |{audioBits,videoBits,bits}PerSecond| when adding support for them.

};