MediaRecorder: update to spec (3/3)

third_party/WebKit/Source/modules/mediarecorder/MediaRecorder.cpp

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "config.h"
 #include "modules/mediarecorder/MediaRecorder.h"
 
 #include "bindings/core/v8/Dictionary.h"
-#include "core/dom/DOMError.h"
+#include "core/events/Event.h"
 #include "core/fileapi/Blob.h"
-#include "modules/EventModules.h"
 #include "modules/EventTargetModules.h"
 #include "modules/mediarecorder/BlobEvent.h"
-#include "modules/mediarecorder/MediaRecorderErrorEvent.h"
 #include "platform/ContentType.h"
 #include "platform/NotImplemented.h"
 #include "platform/blob/BlobData.h"
 #include "public/platform/Platform.h"
 #include "public/platform/WebMediaStream.h"
 
 namespace blink {
 
 namespace {
 
@@ skipping 192 matching lines @@
         m_blobData->appendBytes(data, length);
 
     if (!lastInSlice)
         return;
 
     // Cache |m_blobData->length()| before release()ng it.
     const long long blobDataLength = m_blobData->length();
     createBlobEvent(Blob::create(BlobDataHandle::create(m_blobData.release(), blobDataLength)));
 }
 
 void MediaRecorder::failOutOfMemory(const WebString& message)

[Peter Beverloo, 2015/12/22 11:59:35]

A few thoughts:

  (1) I think it's unfortunate that we're losing the error messages, this
reduces clarity. But if this improves alignment with the other media drafts, ok.
  (2) The MediaRecorder::fail*() methods actually aren't being called by our
implementation. Do you plan to call them?
  (3) The three MediaRecorder::fail*() methods are now identical. Can we unify
them into a single implementation?

I'm confused about ErrorEvent - there seem to be two? Let me reply to the GitHub
issue on that note.

[mcasas, 2015/12/22 20:24:40]

It is, I filed corresponding issues to track this situation:
https://github.com/w3c/mediacapture-record/issues/42
and
https://github.com/w3c/mediacapture-main/issues/298
Yes, there's a parallel CL calling fallingIllegalStreamModification()
when there's a Track added or removed, see https://crrev.com/1543673002
We should! Let me do that.

 {
-    scheduleDispatchEvent(MediaRecorderErrorEvent::create(
-        EventTypeNames::error, false, false, "OutOfMemory", message));
+    scheduleDispatchEvent(Event::create(EventTypeNames::error));
 
     if (m_state == State::Recording)
         stopRecording();
 }
 
 void MediaRecorder::failIllegalStreamModification(const WebString& message)
 {
-    scheduleDispatchEvent(MediaRecorderErrorEvent::create(
-        EventTypeNames::error, false, false, "IllegalStreamModification", message));
+    scheduleDispatchEvent(Event::create(EventTypeNames::error));
 
     if (m_state == State::Recording)
         stopRecording();
 }
 
 void MediaRecorder::failOtherRecordingError(const WebString& message)
 {
-    scheduleDispatchEvent(MediaRecorderErrorEvent::create(
-        EventTypeNames::error, false, false, "OtherRecordingError", message));
+    scheduleDispatchEvent(Event::create(EventTypeNames::error));
 
     if (m_state == State::Recording)
         stopRecording();
 }
 
 void MediaRecorder::createBlobEvent(Blob* blob)
 {
     // TODO(mcasas): Consider launching an Event with a TypedArray inside, see https://github.com/w3c/mediacapture-record/issues/17.
     scheduleDispatchEvent(BlobEvent::create(EventTypeNames::dataavailable, blob));
 }
@@ skipping 27 matching lines @@
 
 DEFINE_TRACE(MediaRecorder)
 {
     visitor->trace(m_stream);
     visitor->trace(m_scheduledEvents);
     RefCountedGarbageCollectedEventTargetWithInlineData<MediaRecorder>::trace(visitor);
     ActiveDOMObject::trace(visitor);
 }
 
 } // namespace blink