Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issue 1539583003: Convert Pass()→std::move() in ui/ (Closed)

Created:
5 years ago by dcheng
Modified:
5 years ago
Reviewers:
Avi (use Gerrit)
CC:
cc-bugs_chromium.org, chromium-reviews, danakj+watch_chromium.org, groby+bubble_chromium.org, hcarmona+bubble_chromium.org, jbauman+watch_chromium.org, jshin+watch_chromium.org, kalyank, Matt Giuca, mlamouri+watch-notifications_chromium.org, msw+watch_chromium.org, nona+watch_chromium.org, Peter Beverloo, piman+watch_chromium.org, rouslan+bubble_chromium.org, sadrul, shuchen+watch_chromium.org, sievers+watch_chromium.org, James Su, tapted, tdanderson+views_chromium.org, tdresser+watch_chromium.org, tfarina, Ian Vollick, yusukes+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert Pass()→std::move() in ui/ BUG=557422 Committed: https://crrev.com/79c14496c5d2a2b534abb1163f3ef50bbbf42d8c Cr-Commit-Position: refs/heads/master@{#366017}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+446 lines, -298 lines) Patch
M ui/app_list/app_list_item_list_unittest.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M ui/app_list/app_list_model.cc View 12 chunks +19 lines, -17 lines 0 comments Download
M ui/app_list/folder_image_unittest.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M ui/app_list/search/dictionary_data_store.cc View 2 chunks +3 lines, -1 line 0 comments Download
M ui/app_list/search/history.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/app_list/search/history_data.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/app_list/search/history_data_store.cc View 3 chunks +4 lines, -2 lines 0 comments Download
M ui/app_list/search/mixer_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/app_list/search_box_model.cc View 2 chunks +3 lines, -1 line 0 comments Download
M ui/app_list/search_controller.cc View 2 chunks +2 lines, -1 line 0 comments Download
M ui/app_list/search_provider.cc View 2 chunks +3 lines, -1 line 0 comments Download
M ui/app_list/test/app_list_test_model.cc View 2 chunks +3 lines, -1 line 0 comments Download
M ui/aura/env.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/aura/scoped_window_targeter.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M ui/aura/test/aura_test_utils.cc View 3 chunks +4 lines, -2 lines 0 comments Download
M ui/aura/test/env_test_helper.h View 2 chunks +3 lines, -1 line 0 comments Download
M ui/aura/window.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M ui/aura/window_event_dispatcher_unittest.cc View 4 chunks +4 lines, -3 lines 0 comments Download
M ui/aura/window_targeter_unittest.cc View 2 chunks +3 lines, -1 line 0 comments Download
M ui/aura/window_tree_host_platform.cc View 2 chunks +3 lines, -1 line 0 comments Download
M ui/base/accelerators/accelerator.h View 2 chunks +3 lines, -1 line 0 comments Download
M ui/base/l10n/formatter.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M ui/base/models/list_model.h View 2 chunks +3 lines, -1 line 0 comments Download
M ui/base/resource/data_pack.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M ui/base/resource/data_pack_unittest.cc View 5 chunks +7 lines, -4 lines 0 comments Download
M ui/base/resource/resource_bundle.cc View 4 chunks +6 lines, -4 lines 0 comments Download
M ui/compositor/compositor.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M ui/compositor/layer.cc View 6 chunks +7 lines, -6 lines 0 comments Download
M ui/compositor/layer_animation_element.cc View 5 chunks +8 lines, -6 lines 0 comments Download
M ui/compositor/layer_owner.cc View 3 chunks +5 lines, -3 lines 0 comments Download
M ui/compositor/layer_unittest.cc View 4 chunks +7 lines, -4 lines 0 comments Download
M ui/compositor/scoped_layer_animation_settings.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/compositor/test/in_process_context_factory.cc View 3 chunks +5 lines, -3 lines 0 comments Download
M ui/events/devices/x11/device_data_manager_x11.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/events/event.cc View 2 chunks +3 lines, -1 line 0 comments Download
M ui/events/event_processor_unittest.cc View 8 chunks +13 lines, -11 lines 0 comments Download
M ui/events/event_utils.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/events/gesture_detection/motion_event_buffer.cc View 14 chunks +18 lines, -15 lines 0 comments Download
M ui/events/gesture_detection/motion_event_buffer_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/events/gesture_detection/motion_event_generic.cc View 4 chunks +4 lines, -3 lines 0 comments Download
M ui/events/gesture_detection/motion_event_generic_unittest.cc View 3 chunks +6 lines, -4 lines 0 comments Download
M ui/events/gestures/blink/web_gesture_curve_impl.cc View 2 chunks +6 lines, -5 lines 0 comments Download
M ui/events/gestures/gesture_provider_aura.cc View 2 chunks +3 lines, -1 line 0 comments Download
M ui/events/latency_info.cc View 3 chunks +5 lines, -3 lines 0 comments Download
M ui/events/platform/platform_event_source_unittest.cc View 6 chunks +8 lines, -6 lines 0 comments Download
M ui/events/scoped_target_handler_unittest.cc View 6 chunks +8 lines, -6 lines 0 comments Download
M ui/events/test/event_generator.cc View 2 chunks +3 lines, -1 line 0 comments Download
M ui/events/test/test_event_processor.cc View 2 chunks +3 lines, -1 line 0 comments Download
M ui/events/test/test_event_target.cc View 3 chunks +4 lines, -2 lines 0 comments Download
M ui/events/x/events_x_unittest.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M ui/message_center/message_center_impl.cc View 12 chunks +20 lines, -19 lines 0 comments Download
M ui/message_center/message_center_impl_unittest.cc View 18 chunks +45 lines, -43 lines 0 comments Download
M ui/message_center/message_center_tray_unittest.cc View 4 chunks +5 lines, -3 lines 0 comments Download
M ui/message_center/views/message_center_view_unittest.cc View 4 chunks +5 lines, -3 lines 0 comments Download
M ui/message_center/views/message_popup_collection_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M ui/message_center/views/message_view.cc View 1 chunk +1 line, -2 lines 0 comments Download
M ui/native_theme/native_theme_aura.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M ui/snapshot/snapshot_aura.cc View 2 chunks +3 lines, -1 line 0 comments Download
M ui/views/bubble/bubble_frame_view.cc View 2 chunks +2 lines, -1 line 0 comments Download
M ui/views/controls/button/blue_button.cc View 2 chunks +3 lines, -1 line 0 comments Download
M ui/views/controls/button/checkbox.cc View 2 chunks +3 lines, -1 line 0 comments Download
M ui/views/controls/button/image_button.cc View 2 chunks +3 lines, -1 line 0 comments Download
M ui/views/controls/button/label_button.cc View 3 chunks +4 lines, -2 lines 0 comments Download
M ui/views/controls/combobox/combobox.cc View 2 chunks +3 lines, -1 line 0 comments Download
M ui/views/controls/image_view.cc View 2 chunks +3 lines, -1 line 0 comments Download
M ui/views/controls/label.cc View 4 chunks +4 lines, -3 lines 0 comments Download
M ui/views/controls/menu/menu_runner.cc View 2 chunks +3 lines, -1 line 0 comments Download
M ui/views/controls/styled_label.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/controls/table/table_view.cc View 2 chunks +2 lines, -1 line 0 comments Download
M ui/views/controls/textfield/textfield.cc View 2 chunks +2 lines, -1 line 0 comments Download
M ui/views/controls/webview/webview.cc View 2 chunks +5 lines, -3 lines 0 comments Download
M ui/views/corewm/tooltip_controller.cc View 2 chunks +2 lines, -1 line 0 comments Download
M ui/views/examples/examples_window.cc View 5 chunks +7 lines, -5 lines 0 comments Download
M ui/views/examples/examples_window_with_content.cc View 2 chunks +3 lines, -1 line 0 comments Download
M ui/views/mus/aura_init.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M ui/views/mus/input_method_mus.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M ui/views/mus/surface_binding.cc View 2 chunks +2 lines, -1 line 0 comments Download
M ui/views/mus/window_manager_connection.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M ui/views/style/platform_style.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/test/menu_runner_test_api.cc View 2 chunks +3 lines, -1 line 0 comments Download
M ui/views/test/scoped_views_test_helper.cc View 2 chunks +3 lines, -1 line 0 comments Download
M ui/views/test/views_test_base.cc View 2 chunks +3 lines, -1 line 0 comments Download
M ui/views/test/x11_property_change_waiter.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/views/view.cc View 4 chunks +8 lines, -5 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_focus_rules_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/widget/desktop_aura/desktop_native_cursor_manager.cc View 2 chunks +3 lines, -1 line 0 comments Download
M ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc View 3 chunks +5 lines, -4 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_window_tree_host_x11_interactive_uitest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/widget/desktop_aura/desktop_window_tree_host_x11_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/widget/desktop_aura/x11_topmost_window_finder_interactive_uitest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/widget/desktop_aura/x11_whole_screen_move_loop.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M ui/views/window/dialog_delegate.cc View 2 chunks +3 lines, -1 line 0 comments Download
M ui/views_content_client/views_content_browser_client.cc View 2 chunks +3 lines, -1 line 0 comments Download
M ui/views_content_client/views_content_client_main_parts.cc View 2 chunks +3 lines, -1 line 0 comments Download
M ui/wm/core/accelerator_filter.cc View 2 chunks +3 lines, -1 line 0 comments Download
M ui/wm/core/capture_controller_unittest.cc View 3 chunks +6 lines, -2 lines 0 comments Download
M ui/wm/core/cursor_manager.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M ui/wm/core/nested_accelerator_controller.cc View 3 chunks +4 lines, -2 lines 0 comments Download
M ui/wm/core/transient_window_manager_unittest.cc View 3 chunks +6 lines, -2 lines 0 comments Download
M ui/wm/core/window_util.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (7 generated)
dcheng
You volunteered as tribute =)
5 years ago (2015-12-18 02:19:57 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1539583003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1539583003/1
5 years ago (2015-12-18 02:21:20 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years ago (2015-12-18 03:28:16 UTC) #6
Avi (use Gerrit)
On 2015/12/18 03:28:16, commit-bot: I haz the power wrote: > Dry run: This issue passed ...
5 years ago (2015-12-18 04:31:16 UTC) #8
dcheng
On 2015/12/18 at 04:31:16, avi wrote: > On 2015/12/18 03:28:16, commit-bot: I haz the power ...
5 years ago (2015-12-18 04:59:54 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1539583003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1539583003/1
5 years ago (2015-12-18 05:00:29 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-18 05:07:35 UTC) #13
commit-bot: I haz the power
5 years ago (2015-12-18 05:08:26 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/79c14496c5d2a2b534abb1163f3ef50bbbf42d8c
Cr-Commit-Position: refs/heads/master@{#366017}

Powered by Google App Engine
This is Rietveld 408576698