Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1450)

Unified Diff: ui/wm/core/transient_window_manager_unittest.cc

Issue 1539583003: Convert Pass()→std::move() in ui/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/wm/core/nested_accelerator_controller.cc ('k') | ui/wm/core/window_util.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/wm/core/transient_window_manager_unittest.cc
diff --git a/ui/wm/core/transient_window_manager_unittest.cc b/ui/wm/core/transient_window_manager_unittest.cc
index 21553720bff92b338167ebd937ad778034abb107..81e82023b66bd7e0271f2c860ac14d5ebd67a5c3 100644
--- a/ui/wm/core/transient_window_manager_unittest.cc
+++ b/ui/wm/core/transient_window_manager_unittest.cc
@@ -4,6 +4,8 @@
#include "ui/wm/core/transient_window_manager.h"
+#include <utility>
+
#include "ui/aura/client/window_tree_client.h"
#include "ui/aura/test/aura_test_base.h"
#include "ui/aura/test/test_windows.h"
@@ -49,7 +51,8 @@ class WindowVisibilityObserver : public aura::WindowObserver {
public:
WindowVisibilityObserver(Window* observed_window,
scoped_ptr<Window> owned_window)
- : observed_window_(observed_window), owned_window_(owned_window.Pass()) {
+ : observed_window_(observed_window),
+ owned_window_(std::move(owned_window)) {
observed_window_->AddObserver(this);
}
~WindowVisibilityObserver() override {
@@ -342,7 +345,8 @@ TEST_F(TransientWindowManagerTest, CrashOnVisibilityChange) {
window1->Show();
window2->Show();
- WindowVisibilityObserver visibility_observer(window1.get(), window2.Pass());
+ WindowVisibilityObserver visibility_observer(window1.get(),
+ std::move(window2));
root_window()->Hide();
}
// Tests that windows are restacked properly after a call to AddTransientChild()
« no previous file with comments | « ui/wm/core/nested_accelerator_controller.cc ('k') | ui/wm/core/window_util.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698