Takes ShapeBounding rectangles into consideration in WindowContainsPoint

Takes ShapeBounding rectangles into consideration in WindowContainsPoint. This is a followup on https://chromiumcodereview.appspot.com/10990010.

BUG=319795
TEST=in chromoting session to a Ubuntu machine launch chrome and drag a bookmark changing the order of bookmarks (should not hang).
TEST=in chrome://settings page drag "Google Dashboard." link to omnibox (should not hang).

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=248911

[varkha, 2014-02-04 20:48:38]

sadrul@, not sure if this fixes all manifestations mentioned in the bug but this
at least allows the drag to continue on a unity-2d-shell desktop. Can you please
take a look?

[sadrul, 2014-02-04 23:12:17]

https://codereview.chromium.org/153953006/diff/40001/ui/base/x/x11_util.cc
File ui/base/x/x11_util.cc (right):

https://codereview.chromium.org/153953006/diff/40001/ui/base/x/x11_util.cc#ne...
ui/base/x/x11_util.cc:668: kind_index <
sizeof(rectangle_kind)/sizeof(*rectangle_kind) ;
You can use the arraysize macro here instead.

https://codereview.chromium.org/153953006/diff/40001/ui/base/x/x11_util.cc#ne...
ui/base/x/x11_util.cc:698: return is_in_shape_rects;
I think you can move is_in_shape_rects inside the for loop (in line 681), and
always return true from here.

[varkha, 2014-02-05 03:52:31]

PTAL, thanks.

https://codereview.chromium.org/153953006/diff/40001/ui/base/x/x11_util.cc
File ui/base/x/x11_util.cc (right):

https://codereview.chromium.org/153953006/diff/40001/ui/base/x/x11_util.cc#ne...
ui/base/x/x11_util.cc:668: kind_index <
sizeof(rectangle_kind)/sizeof(*rectangle_kind) ;
On 2014/02/04 23:12:18, sadrul wrote:
> You can use the arraysize macro here instead.

Done.

https://codereview.chromium.org/153953006/diff/40001/ui/base/x/x11_util.cc#ne...
ui/base/x/x11_util.cc:698: return is_in_shape_rects;
On 2014/02/04 23:12:18, sadrul wrote:
> I think you can move is_in_shape_rects inside the for loop (in line 681), and
> always return true from here.

Done.

[sadrul, 2014-02-05 03:54:00]

Cool. LGTM

[varkha, 2014-02-05 03:54:56]

The CQ bit was checked by varkha@chromium.org

[commit-bot: I haz the power, 2014-02-05 04:13:33]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/varkha@chromium.org/153953006/110001

[commit-bot: I haz the power, 2014-02-05 07:50:58]

Change committed as 248911