Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1539353003: Switch to standard integer types in crypto/. (Closed)

Created:
5 years ago by Avi (use Gerrit)
Modified:
5 years ago
Reviewers:
Ryan Sleevi
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Switch to standard integer types in crypto/. BUG=138542 TBR=rsleevi@chromium.org NOPRESUBMIT=true Committed: https://crrev.com/dd373b8b7d7501cf7f3bbfe861f58dce67578a69 Cr-Commit-Position: refs/heads/master@{#366460}

Patch Set 1 #

Patch Set 2 : arraysie #

Patch Set 3 : fixes #

Patch Set 4 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1051 lines, -1010 lines) Patch
M crypto/aead_openssl.h View 1 chunk +2 lines, -0 lines 0 comments Download
M crypto/aead_openssl.cc View 5 chunks +15 lines, -13 lines 0 comments Download
M crypto/apple_keychain.h View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M crypto/capi_util.h View 1 chunk +1 line, -0 lines 0 comments Download
M crypto/capi_util.cc View 1 chunk +3 lines, -1 line 0 comments Download
M crypto/cssm_init.h View 1 chunk +1 line, -1 line 0 comments Download
M crypto/cssm_init.cc View 2 chunks +2 lines, -1 line 0 comments Download
M crypto/curve25519_nss.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M crypto/curve25519_openssl.cc View 1 chunk +1 line, -0 lines 0 comments Download
M crypto/curve25519_unittest.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M crypto/ec_private_key.h View 4 chunks +11 lines, -8 lines 0 comments Download
M crypto/ec_private_key_nss.cc View 7 chunks +12 lines, -11 lines 0 comments Download
M crypto/ec_private_key_openssl.cc View 9 chunks +14 lines, -13 lines 0 comments Download
M crypto/ec_private_key_unittest.cc View 9 chunks +35 lines, -34 lines 0 comments Download
M crypto/ec_signature_creator.h View 2 chunks +6 lines, -5 lines 0 comments Download
M crypto/ec_signature_creator_impl.h View 2 chunks +7 lines, -4 lines 0 comments Download
M crypto/ec_signature_creator_nss.cc View 5 chunks +9 lines, -7 lines 0 comments Download
M crypto/ec_signature_creator_openssl.cc View 4 chunks +8 lines, -5 lines 0 comments Download
M crypto/ec_signature_creator_unittest.cc View 5 chunks +11 lines, -12 lines 0 comments Download
M crypto/encryptor.h View 3 chunks +6 lines, -4 lines 0 comments Download
M crypto/encryptor.cc View 5 chunks +10 lines, -7 lines 0 comments Download
M crypto/encryptor_nss.cc View 4 chunks +10 lines, -9 lines 0 comments Download
M crypto/encryptor_openssl.cc View 5 chunks +12 lines, -11 lines 0 comments Download
M crypto/encryptor_unittest.cc View 1 1 chunk +3 lines, -0 lines 0 comments Download
M crypto/ghash.h View 5 chunks +10 lines, -8 lines 0 comments Download
M crypto/ghash.cc View 9 chunks +18 lines, -15 lines 0 comments Download
M crypto/ghash_unittest.cc View 1 4 chunks +31 lines, -30 lines 0 comments Download
M crypto/hkdf.h View 2 chunks +4 lines, -2 lines 0 comments Download
M crypto/hkdf.cc View 3 chunks +5 lines, -2 lines 0 comments Download
M crypto/hkdf_unittest.cc View 1 2 chunks +5 lines, -1 line 0 comments Download
M crypto/hmac.h View 1 chunk +3 lines, -1 line 0 comments Download
M crypto/hmac.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M crypto/hmac_nss.cc View 1 chunk +1 line, -0 lines 0 comments Download
M crypto/hmac_openssl.cc View 1 chunk +1 line, -0 lines 0 comments Download
M crypto/hmac_unittest.cc View 1 1 chunk +3 lines, -0 lines 0 comments Download
M crypto/hmac_win.cc View 1 chunk +1 line, -0 lines 0 comments Download
M crypto/mac_security_services_lock.cc View 1 chunk +1 line, -0 lines 0 comments Download
M crypto/mock_apple_keychain.h View 1 chunk +1 line, -0 lines 0 comments Download
M crypto/mock_apple_keychain.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M crypto/mock_apple_keychain_mac.cc View 1 1 chunk +3 lines, -0 lines 0 comments Download
M crypto/nss_key_util.cc View 1 chunk +1 line, -0 lines 0 comments Download
M crypto/nss_key_util_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M crypto/nss_util.h View 2 chunks +7 lines, -5 lines 0 comments Download
M crypto/nss_util_internal.h View 1 chunk +1 line, -0 lines 0 comments Download
M crypto/openssl_util.h View 1 chunk +3 lines, -1 line 0 comments Download
M crypto/openssl_util.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M crypto/p224.h View 3 chunks +8 lines, -4 lines 0 comments Download
M crypto/p224.cc View 26 chunks +59 lines, -55 lines 0 comments Download
M crypto/p224_spake.h View 2 chunks +13 lines, -12 lines 0 comments Download
M crypto/p224_spake.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M crypto/p224_spake_unittest.cc View 2 chunks +4 lines, -1 line 0 comments Download
M crypto/p224_unittest.cc View 1 3 chunks +13 lines, -12 lines 0 comments Download
M crypto/random.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M crypto/random_unittest.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M crypto/rsa_private_key.h View 5 chunks +62 lines, -57 lines 0 comments Download
M crypto/rsa_private_key.cc View 15 chunks +64 lines, -58 lines 0 comments Download
M crypto/rsa_private_key_nss.cc View 6 chunks +6 lines, -5 lines 0 comments Download
M crypto/rsa_private_key_openssl.cc View 5 chunks +6 lines, -5 lines 0 comments Download
M crypto/rsa_private_key_unittest.cc View 12 chunks +207 lines, -298 lines 0 comments Download
M crypto/scoped_capi_types.h View 1 chunk +1 line, -0 lines 0 comments Download
M crypto/scoped_openssl_types.h View 1 chunk +1 line, -0 lines 0 comments Download
M crypto/secure_hash.h View 1 chunk +3 lines, -1 line 0 comments Download
M crypto/secure_hash_default.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M crypto/secure_hash_openssl.cc View 1 chunk +1 line, -1 line 0 comments Download
M crypto/secure_hash_unittest.cc View 3 chunks +6 lines, -4 lines 0 comments Download
M crypto/secure_util.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M crypto/sha2.h View 1 chunk +2 lines, -0 lines 0 comments Download
M crypto/sha2.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M crypto/sha2_unittest.cc View 5 chunks +10 lines, -8 lines 0 comments Download
M crypto/signature_creator.h View 2 chunks +7 lines, -5 lines 0 comments Download
M crypto/signature_creator_nss.cc View 4 chunks +5 lines, -4 lines 0 comments Download
M crypto/signature_creator_openssl.cc View 3 chunks +6 lines, -4 lines 0 comments Download
M crypto/signature_creator_unittest.cc View 11 chunks +25 lines, -31 lines 0 comments Download
M crypto/signature_verifier.h View 4 chunks +16 lines, -15 lines 0 comments Download
M crypto/signature_verifier_nss.cc View 7 chunks +11 lines, -10 lines 0 comments Download
M crypto/signature_verifier_openssl.cc View 5 chunks +9 lines, -8 lines 0 comments Download
M crypto/signature_verifier_unittest.cc View 1 10 chunks +178 lines, -182 lines 0 comments Download
M crypto/symmetric_key.h View 1 2 1 chunk +4 lines, -1 line 0 comments Download
M crypto/symmetric_key_nss.cc View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M crypto/symmetric_key_openssl.cc View 3 chunks +8 lines, -7 lines 0 comments Download
M crypto/symmetric_key_win.cc View 4 chunks +6 lines, -3 lines 0 comments Download
M crypto/third_party/nss/secsign.cc View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 27 (14 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1539353003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1539353003/1
5 years ago (2015-12-21 17:21:08 UTC) #2
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_ninja/builds/110394) ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED, ...
5 years ago (2015-12-21 17:27:11 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1539353003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1539353003/20001
5 years ago (2015-12-21 18:14:29 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/130934)
5 years ago (2015-12-21 18:22:57 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1539353003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1539353003/20001
5 years ago (2015-12-21 19:33:53 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_ninja/builds/110455) ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED, ...
5 years ago (2015-12-21 19:45:58 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1539353003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1539353003/20001
5 years ago (2015-12-21 19:51:33 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_ninja/builds/110469) ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED, ...
5 years ago (2015-12-21 20:03:25 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1539353003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1539353003/40001
5 years ago (2015-12-21 20:12:25 UTC) #19
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_ninja/builds/110481)
5 years ago (2015-12-21 20:21:53 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1539353003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1539353003/60001
5 years ago (2015-12-21 20:27:55 UTC) #23
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years ago (2015-12-21 21:34:54 UTC) #25
commit-bot: I haz the power
5 years ago (2015-12-21 21:35:58 UTC) #27
Message was sent while issue was closed. 
Patchset 4 (id:??) landed as
https://crrev.com/dd373b8b7d7501cf7f3bbfe861f58dce67578a69
Cr-Commit-Position: refs/heads/master@{#366460}

Powered by Google App Engine
This is Rietveld 408576698