Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(422)

Side by Side Diff: crypto/signature_verifier_nss.cc

Issue 1539353003: Switch to standard integer types in crypto/. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « crypto/signature_verifier.h ('k') | crypto/signature_verifier_openssl.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "crypto/signature_verifier.h" 5 #include "crypto/signature_verifier.h"
6 6
7 #include <cryptohi.h> 7 #include <cryptohi.h>
8 #include <keyhi.h> 8 #include <keyhi.h>
9 #include <pk11pub.h> 9 #include <pk11pub.h>
10 #include <secerr.h> 10 #include <secerr.h>
11 #include <sechash.h> 11 #include <sechash.h>
12 #include <stdint.h>
12 #include <stdlib.h> 13 #include <stdlib.h>
13 14
14 #include "base/logging.h" 15 #include "base/logging.h"
15 #include "crypto/nss_util.h" 16 #include "crypto/nss_util.h"
16 #include "crypto/third_party/nss/chromium-nss.h" 17 #include "crypto/third_party/nss/chromium-nss.h"
17 18
18 namespace crypto { 19 namespace crypto {
19 20
20 namespace { 21 namespace {
21 22
(...skipping 44 matching lines...) Expand 10 before | Expand all | Expand 10 after
66 salt_len_(0), 67 salt_len_(0),
67 public_key_(NULL), 68 public_key_(NULL),
68 hash_context_(NULL) { 69 hash_context_(NULL) {
69 EnsureNSSInit(); 70 EnsureNSSInit();
70 } 71 }
71 72
72 SignatureVerifier::~SignatureVerifier() { 73 SignatureVerifier::~SignatureVerifier() {
73 Reset(); 74 Reset();
74 } 75 }
75 76
76 bool SignatureVerifier::VerifyInit(const uint8* signature_algorithm, 77 bool SignatureVerifier::VerifyInit(const uint8_t* signature_algorithm,
77 int signature_algorithm_len, 78 int signature_algorithm_len,
78 const uint8* signature, 79 const uint8_t* signature,
79 int signature_len, 80 int signature_len,
80 const uint8* public_key_info, 81 const uint8_t* public_key_info,
81 int public_key_info_len) { 82 int public_key_info_len) {
82 if (vfy_context_ || hash_context_) 83 if (vfy_context_ || hash_context_)
83 return false; 84 return false;
84 85
85 signature_.assign(signature, signature + signature_len); 86 signature_.assign(signature, signature + signature_len);
86 87
87 SECKEYPublicKey* public_key = DecodePublicKeyInfo(public_key_info, 88 SECKEYPublicKey* public_key = DecodePublicKeyInfo(public_key_info,
88 public_key_info_len); 89 public_key_info_len);
89 if (!public_key) 90 if (!public_key)
90 return false; 91 return false;
91 92
92 PLArenaPool* arena = PORT_NewArena(DER_DEFAULT_CHUNKSIZE); 93 PLArenaPool* arena = PORT_NewArena(DER_DEFAULT_CHUNKSIZE);
93 if (!arena) { 94 if (!arena) {
94 SECKEY_DestroyPublicKey(public_key); 95 SECKEY_DestroyPublicKey(public_key);
95 return false; 96 return false;
96 } 97 }
97 98
98 SECItem sig_alg_der; 99 SECItem sig_alg_der;
99 sig_alg_der.type = siBuffer; 100 sig_alg_der.type = siBuffer;
100 sig_alg_der.data = const_cast<uint8*>(signature_algorithm); 101 sig_alg_der.data = const_cast<uint8_t*>(signature_algorithm);
101 sig_alg_der.len = signature_algorithm_len; 102 sig_alg_der.len = signature_algorithm_len;
102 SECAlgorithmID sig_alg_id; 103 SECAlgorithmID sig_alg_id;
103 SECStatus rv; 104 SECStatus rv;
104 rv = SEC_QuickDERDecodeItem(arena, &sig_alg_id, 105 rv = SEC_QuickDERDecodeItem(arena, &sig_alg_id,
105 SEC_ASN1_GET(SECOID_AlgorithmIDTemplate), 106 SEC_ASN1_GET(SECOID_AlgorithmIDTemplate),
106 &sig_alg_der); 107 &sig_alg_der);
107 if (rv != SECSuccess) { 108 if (rv != SECSuccess) {
108 SECKEY_DestroyPublicKey(public_key); 109 SECKEY_DestroyPublicKey(public_key);
109 PORT_FreeArena(arena, PR_TRUE); 110 PORT_FreeArena(arena, PR_TRUE);
110 return false; 111 return false;
111 } 112 }
112 113
113 SECItem sig; 114 SECItem sig;
114 sig.type = siBuffer; 115 sig.type = siBuffer;
115 sig.data = const_cast<uint8*>(signature); 116 sig.data = const_cast<uint8_t*>(signature);
116 sig.len = signature_len; 117 sig.len = signature_len;
117 SECOidTag hash_alg_tag; 118 SECOidTag hash_alg_tag;
118 vfy_context_ = VFY_CreateContextWithAlgorithmID(public_key, &sig, 119 vfy_context_ = VFY_CreateContextWithAlgorithmID(public_key, &sig,
119 &sig_alg_id, &hash_alg_tag, 120 &sig_alg_id, &hash_alg_tag,
120 NULL); 121 NULL);
121 SECKEY_DestroyPublicKey(public_key); // Done with public_key. 122 SECKEY_DestroyPublicKey(public_key); // Done with public_key.
122 PORT_FreeArena(arena, PR_TRUE); // Done with sig_alg_id. 123 PORT_FreeArena(arena, PR_TRUE); // Done with sig_alg_id.
123 if (!vfy_context_) { 124 if (!vfy_context_) {
124 // A corrupted RSA signature could be detected without the data, so 125 // A corrupted RSA signature could be detected without the data, so
125 // VFY_CreateContextWithAlgorithmID may fail with SEC_ERROR_BAD_SIGNATURE 126 // VFY_CreateContextWithAlgorithmID may fail with SEC_ERROR_BAD_SIGNATURE
126 // (-8182). 127 // (-8182).
127 return false; 128 return false;
128 } 129 }
129 130
130 rv = VFY_Begin(vfy_context_); 131 rv = VFY_Begin(vfy_context_);
131 if (rv != SECSuccess) { 132 if (rv != SECSuccess) {
132 NOTREACHED(); 133 NOTREACHED();
133 return false; 134 return false;
134 } 135 }
135 return true; 136 return true;
136 } 137 }
137 138
138 bool SignatureVerifier::VerifyInitRSAPSS(HashAlgorithm hash_alg, 139 bool SignatureVerifier::VerifyInitRSAPSS(HashAlgorithm hash_alg,
139 HashAlgorithm mask_hash_alg, 140 HashAlgorithm mask_hash_alg,
140 int salt_len, 141 int salt_len,
141 const uint8* signature, 142 const uint8_t* signature,
142 int signature_len, 143 int signature_len,
143 const uint8* public_key_info, 144 const uint8_t* public_key_info,
144 int public_key_info_len) { 145 int public_key_info_len) {
145 if (vfy_context_ || hash_context_) 146 if (vfy_context_ || hash_context_)
146 return false; 147 return false;
147 148
148 signature_.assign(signature, signature + signature_len); 149 signature_.assign(signature, signature + signature_len);
149 150
150 SECKEYPublicKey* public_key = DecodePublicKeyInfo(public_key_info, 151 SECKEYPublicKey* public_key = DecodePublicKeyInfo(public_key_info,
151 public_key_info_len); 152 public_key_info_len);
152 if (!public_key) 153 if (!public_key)
153 return false; 154 return false;
154 155
155 public_key_ = public_key; 156 public_key_ = public_key;
156 hash_alg_ = hash_alg; 157 hash_alg_ = hash_alg;
157 mask_hash_alg_ = mask_hash_alg; 158 mask_hash_alg_ = mask_hash_alg;
158 salt_len_ = salt_len; 159 salt_len_ = salt_len;
159 hash_context_ = HASH_Create(ToNSSHashType(hash_alg_)); 160 hash_context_ = HASH_Create(ToNSSHashType(hash_alg_));
160 if (!hash_context_) 161 if (!hash_context_)
161 return false; 162 return false;
162 HASH_Begin(hash_context_); 163 HASH_Begin(hash_context_);
163 return true; 164 return true;
164 } 165 }
165 166
166 void SignatureVerifier::VerifyUpdate(const uint8* data_part, 167 void SignatureVerifier::VerifyUpdate(const uint8_t* data_part,
167 int data_part_len) { 168 int data_part_len) {
168 if (vfy_context_) { 169 if (vfy_context_) {
169 SECStatus rv = VFY_Update(vfy_context_, data_part, data_part_len); 170 SECStatus rv = VFY_Update(vfy_context_, data_part, data_part_len);
170 DCHECK_EQ(SECSuccess, rv); 171 DCHECK_EQ(SECSuccess, rv);
171 } else { 172 } else {
172 HASH_Update(hash_context_, data_part, data_part_len); 173 HASH_Update(hash_context_, data_part, data_part_len);
173 } 174 }
174 } 175 }
175 176
176 bool SignatureVerifier::VerifyFinal() { 177 bool SignatureVerifier::VerifyFinal() {
177 SECStatus rv; 178 SECStatus rv;
178 if (vfy_context_) { 179 if (vfy_context_) {
179 rv = VFY_End(vfy_context_); 180 rv = VFY_End(vfy_context_);
180 } else { 181 } else {
181 rv = VerifyRSAPSS_End(public_key_, hash_context_, 182 rv = VerifyRSAPSS_End(public_key_, hash_context_,
182 ToNSSHashType(mask_hash_alg_), salt_len_, 183 ToNSSHashType(mask_hash_alg_), salt_len_,
183 signature_.data(), 184 signature_.data(),
184 signature_.size()); 185 signature_.size());
185 } 186 }
186 Reset(); 187 Reset();
187 188
188 // If signature verification fails, the error code is 189 // If signature verification fails, the error code is
189 // SEC_ERROR_BAD_SIGNATURE (-8182). 190 // SEC_ERROR_BAD_SIGNATURE (-8182).
190 return (rv == SECSuccess); 191 return (rv == SECSuccess);
191 } 192 }
192 193
193 // static 194 // static
194 SECKEYPublicKey* SignatureVerifier::DecodePublicKeyInfo( 195 SECKEYPublicKey* SignatureVerifier::DecodePublicKeyInfo(
195 const uint8* public_key_info, 196 const uint8_t* public_key_info,
196 int public_key_info_len) { 197 int public_key_info_len) {
197 CERTSubjectPublicKeyInfo* spki = NULL; 198 CERTSubjectPublicKeyInfo* spki = NULL;
198 SECItem spki_der; 199 SECItem spki_der;
199 spki_der.type = siBuffer; 200 spki_der.type = siBuffer;
200 spki_der.data = const_cast<uint8*>(public_key_info); 201 spki_der.data = const_cast<uint8_t*>(public_key_info);
201 spki_der.len = public_key_info_len; 202 spki_der.len = public_key_info_len;
202 spki = SECKEY_DecodeDERSubjectPublicKeyInfo(&spki_der); 203 spki = SECKEY_DecodeDERSubjectPublicKeyInfo(&spki_der);
203 if (!spki) 204 if (!spki)
204 return NULL; 205 return NULL;
205 SECKEYPublicKey* public_key = SECKEY_ExtractPublicKey(spki); 206 SECKEYPublicKey* public_key = SECKEY_ExtractPublicKey(spki);
206 SECKEY_DestroySubjectPublicKeyInfo(spki); // Done with spki. 207 SECKEY_DestroySubjectPublicKeyInfo(spki); // Done with spki.
207 return public_key; 208 return public_key;
208 } 209 }
209 210
210 void SignatureVerifier::Reset() { 211 void SignatureVerifier::Reset() {
211 if (vfy_context_) { 212 if (vfy_context_) {
212 VFY_DestroyContext(vfy_context_, PR_TRUE); 213 VFY_DestroyContext(vfy_context_, PR_TRUE);
213 vfy_context_ = NULL; 214 vfy_context_ = NULL;
214 } 215 }
215 if (hash_context_) { 216 if (hash_context_) {
216 HASH_Destroy(hash_context_); 217 HASH_Destroy(hash_context_);
217 hash_context_ = NULL; 218 hash_context_ = NULL;
218 } 219 }
219 if (public_key_) { 220 if (public_key_) {
220 SECKEY_DestroyPublicKey(public_key_); 221 SECKEY_DestroyPublicKey(public_key_);
221 public_key_ = NULL; 222 public_key_ = NULL;
222 } 223 }
223 signature_.clear(); 224 signature_.clear();
224 } 225 }
225 226
226 } // namespace crypto 227 } // namespace crypto
OLDNEW
« no previous file with comments | « crypto/signature_verifier.h ('k') | crypto/signature_verifier_openssl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698