Issue 153893009: A64: Set function type correctly in CallFunctionStub.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 153893009: A64: Set function type correctly in CallFunctionStub. (Closed)

Created:
6 years, 10 months ago by ulan

Modified:
6 years, 10 months ago

Reviewers:
m.m.capewell, jochen (gone - plz use gerrit)

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/experimental/a64

Visibility:
Public.

More Reviews

Description

A64: Set function type correctly in CallFunctionStub. TEST=mjsunit/harmony/proxies-example-membrane R=jochen@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=19240

Patch Set 1 #

Total comments: 2

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -4 lines)			Patch
	M	src/a64/code-stubs-a64.cc	View		1 chunk	+1 line, -1 line	1 comment	Download
	M	src/a64/macro-assembler-a64.cc	View		1 chunk	+1 line, -3 lines	1 comment	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

ulan

PTAL https://codereview.chromium.org/153893009/diff/1/src/a64/code-stubs-a64.cc File src/a64/code-stubs-a64.cc (right): https://codereview.chromium.org/153893009/diff/1/src/a64/code-stubs-a64.cc#newcode3277 src/a64/code-stubs-a64.cc:3277: __ JumpIfNotObjectType(function, x10, type, JS_FUNCTION_TYPE, &slow); The "type" ...

6 years, 10 months ago (2014-02-10 19:28:40 UTC) #1

ulan

6 years, 10 months ago (2014-02-10 19:33:01 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r19240 (presubmit successful).

Expand Messages | Collapse Messages