Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(520)

Side by Side Diff: src/a64/macro-assembler-a64.cc

Issue 153893009: A64: Set function type correctly in CallFunctionStub. (Closed) Base URL: https://v8.googlecode.com/svn/branches/experimental/a64
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« src/a64/code-stubs-a64.cc ('K') | « src/a64/code-stubs-a64.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1320 matching lines...) Expand 10 before | Expand all | Expand 10 after
1331 ExternalReference next_address = 1331 ExternalReference next_address =
1332 ExternalReference::handle_scope_next_address(isolate()); 1332 ExternalReference::handle_scope_next_address(isolate());
1333 const int kNextOffset = 0; 1333 const int kNextOffset = 0;
1334 const int kLimitOffset = AddressOffset( 1334 const int kLimitOffset = AddressOffset(
1335 ExternalReference::handle_scope_limit_address(isolate()), 1335 ExternalReference::handle_scope_limit_address(isolate()),
1336 next_address); 1336 next_address);
1337 const int kLevelOffset = AddressOffset( 1337 const int kLevelOffset = AddressOffset(
1338 ExternalReference::handle_scope_level_address(isolate()), 1338 ExternalReference::handle_scope_level_address(isolate()),
1339 next_address); 1339 next_address);
1340 1340
1341 ASSERT(!AreAliased(function_address, x1, x2)); 1341 ASSERT(function_address.is(x1) || function_address.is(x2));
ulan 2014/02/10 19:28:41 This is from https://codereview.chromium.org/15900
1342 // TODO(all): Why do we care about aliasing x2? (This function uses x1 as a
1343 // scratch regiser.)
1344 1342
1345 Label profiler_disabled; 1343 Label profiler_disabled;
1346 Label end_profiler_check; 1344 Label end_profiler_check;
1347 bool* is_profiling_flag = isolate()->cpu_profiler()->is_profiling_address(); 1345 bool* is_profiling_flag = isolate()->cpu_profiler()->is_profiling_address();
1348 STATIC_ASSERT(sizeof(*is_profiling_flag) == 1); 1346 STATIC_ASSERT(sizeof(*is_profiling_flag) == 1);
1349 Mov(x10, reinterpret_cast<uintptr_t>(is_profiling_flag)); 1347 Mov(x10, reinterpret_cast<uintptr_t>(is_profiling_flag));
1350 Ldrb(w10, MemOperand(x10)); 1348 Ldrb(w10, MemOperand(x10));
1351 Cbz(w10, &profiler_disabled); 1349 Cbz(w10, &profiler_disabled);
1352 1350
1353 // Additional parameter is the address of the actual callback. 1351 // Additional parameter is the address of the actual callback.
(...skipping 3450 matching lines...) Expand 10 before | Expand all | Expand 10 after
4804 } 4802 }
4805 } 4803 }
4806 4804
4807 4805
4808 #undef __ 4806 #undef __
4809 4807
4810 4808
4811 } } // namespace v8::internal 4809 } } // namespace v8::internal
4812 4810
4813 #endif // V8_TARGET_ARCH_A64 4811 #endif // V8_TARGET_ARCH_A64
OLDNEW
« src/a64/code-stubs-a64.cc ('K') | « src/a64/code-stubs-a64.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698