Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(219)

Side by Side Diff: src/a64/code-stubs-a64.cc

Issue 153893009: A64: Set function type correctly in CallFunctionStub. (Closed) Base URL: https://v8.googlecode.com/svn/branches/experimental/a64
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | src/a64/macro-assembler-a64.cc » ('j') | src/a64/macro-assembler-a64.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 3256 matching lines...) Expand 10 before | Expand all | Expand 10 after
3267 Label slow, non_function, wrap, cont; 3267 Label slow, non_function, wrap, cont;
3268 3268
3269 // TODO(jbramley): This function has a lot of unnamed registers. Name them, 3269 // TODO(jbramley): This function has a lot of unnamed registers. Name them,
3270 // and tidy things up a bit. 3270 // and tidy things up a bit.
3271 3271
3272 if (NeedsChecks()) { 3272 if (NeedsChecks()) {
3273 // Check that the function is really a JavaScript function. 3273 // Check that the function is really a JavaScript function.
3274 __ JumpIfSmi(function, &non_function); 3274 __ JumpIfSmi(function, &non_function);
3275 3275
3276 // Goto slow case if we do not have a function. 3276 // Goto slow case if we do not have a function.
3277 __ JumpIfNotObjectType(function, x10, x10, JS_FUNCTION_TYPE, &slow); 3277 __ JumpIfNotObjectType(function, x10, type, JS_FUNCTION_TYPE, &slow);
ulan 2014/02/10 19:28:41 The "type" register is read below in the slow case
3278 3278
3279 if (RecordCallTarget()) { 3279 if (RecordCallTarget()) {
3280 GenerateRecordCallTarget(masm); 3280 GenerateRecordCallTarget(masm);
3281 } 3281 }
3282 } 3282 }
3283 3283
3284 // Fast-case: Invoke the function now. 3284 // Fast-case: Invoke the function now.
3285 // x1 function pushed function 3285 // x1 function pushed function
3286 ParameterCount actual(argc_); 3286 ParameterCount actual(argc_);
3287 3287
(...skipping 2392 matching lines...) Expand 10 before | Expand all | Expand 10 after
5680 MemOperand(fp, 6 * kPointerSize), 5680 MemOperand(fp, 6 * kPointerSize),
5681 NULL); 5681 NULL);
5682 } 5682 }
5683 5683
5684 5684
5685 #undef __ 5685 #undef __
5686 5686
5687 } } // namespace v8::internal 5687 } } // namespace v8::internal
5688 5688
5689 #endif // V8_TARGET_ARCH_A64 5689 #endif // V8_TARGET_ARCH_A64
OLDNEW
« no previous file with comments | « no previous file | src/a64/macro-assembler-a64.cc » ('j') | src/a64/macro-assembler-a64.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698