Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Issue 1542153002: GN(android) Add missing outputs for webview grit rule (Closed)

Created:
5 years ago by agrieve
Modified:
4 years, 12 months ago
Reviewers:
michaelbai
CC:
chromium-reviews, android-webview-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

GN(android) Add missing outputs for webview grit rule Not required in GYP since it doesn't assert outputs. Build fails without this change. BUG=532905 Committed: https://crrev.com/34d23ba076e9559e51d10c297adcb0d0ed8ccb20 Cr-Commit-Position: refs/heads/master@{#367014}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -0 lines) Patch
M android_webview/BUILD.gn View 1 chunk +44 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 10 (3 generated)
agrieve
🎅
5 years ago (2015-12-22 16:38:04 UTC) #2
michaelbai
I didn't run into issue, where did it fail?
4 years, 12 months ago (2015-12-28 20:11:14 UTC) #3
agrieve
On 2015/12/28 20:11:14, michaelbai wrote: > I didn't run into issue, where did it fail? ...
4 years, 12 months ago (2015-12-28 20:29:50 UTC) #4
michaelbai
lgtm aha, I see, thanks
4 years, 12 months ago (2015-12-28 20:42:47 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1542153002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1542153002/1
4 years, 12 months ago (2015-12-28 20:53:36 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 12 months ago (2015-12-28 21:46:55 UTC) #8
commit-bot: I haz the power
4 years, 12 months ago (2015-12-28 21:47:59 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/34d23ba076e9559e51d10c297adcb0d0ed8ccb20
Cr-Commit-Position: refs/heads/master@{#367014}

Powered by Google App Engine
This is Rietveld 408576698