refactor block loading and unloading

refactor block loading and unloading

R=bradnelson@chromium.org
BUG=

Committed: https://crrev.com/e62e287237dcd68a60b5a116eebee6425eaa851e
Cr-Commit-Position: refs/heads/master@{#33139}

[aseemgarg, 2015-12-17 23:26:23]

Please don't lgtm and submit.
Brad, can you see if this looks like a better pattern to encode dealing with
block (I can't go from loops into visitBlock as the types don't match). Also, it
seems we'll need to keep block_size_ as is, especially for for loop as it is
impossible to know which parts of for loop are null without actually visiting

[aseemgarg, 2015-12-19 00:25:39]

Brad, you can LGTM now if the other patch looks fine and can be submitted (this
depends on that).

[bradn, 2016-01-04 23:34:12]

bradnelson@google.com changed reviewers:
+ bradnelson@google.com

[bradn, 2016-01-04 23:34:13]

lgtm

https://codereview.chromium.org/1537743003/diff/40001/src/wasm/asm-wasm-build...
File src/wasm/asm-wasm-builder.cc (right):

https://codereview.chromium.org/1537743003/diff/40001/src/wasm/asm-wasm-build...
src/wasm/asm-wasm-builder.cc:101: class BlockLoader {
BlockVisitor ?

[aseemgarg, 2016-01-05 21:17:08]

aseemgarg@chromium.org changed reviewers:
+ ahaas@chromium.org

[aseemgarg, 2016-01-05 21:17:09]

https://codereview.chromium.org/1537743003/diff/40001/src/wasm/asm-wasm-build...
File src/wasm/asm-wasm-builder.cc (right):

https://codereview.chromium.org/1537743003/diff/40001/src/wasm/asm-wasm-build...
src/wasm/asm-wasm-builder.cc:101: class BlockLoader {
On 2016/01/04 23:34:13, bradn wrote:
> BlockVisitor ?

Done.

[aseemgarg, 2016-01-05 21:17:23]

The CQ bit was checked by aseemgarg@chromium.org

[aseemgarg, 2016-01-05 21:17:23]

The patchset sent to the CQ was uploaded after l-g-t-m from
bradnelson@google.com
Link to the patchset: https://codereview.chromium.org/1537743003/#ps80001
(title: " ")

[commit-bot: I haz the power, 2016-01-05 21:17:28]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1537743003/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1537743003/80001

[commit-bot: I haz the power, 2016-01-05 21:19:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-05 21:19:51]

Try jobs failed on following builders:
  v8_presubmit on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/9463)

[aseemgarg, 2016-01-05 23:55:41]

aseemgarg@chromium.org changed reviewers:
+ titzer@chromium.org

[titzer, 2016-01-06 18:28:58]

LGTM, love it

[aseemgarg, 2016-01-06 20:24:41]

The CQ bit was checked by aseemgarg@chromium.org

[commit-bot: I haz the power, 2016-01-06 20:24:56]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1537743003/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1537743003/80001

[commit-bot: I haz the power, 2016-01-06 20:26:13]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-01-06 20:26:28]

Description was changed from

==========
refactor block loading and unloading

R=bradnelson@chromium.org
BUG=
==========

to

==========
refactor block loading and unloading

R=bradnelson@chromium.org
BUG=

Committed: https://crrev.com/e62e287237dcd68a60b5a116eebee6425eaa851e
Cr-Commit-Position: refs/heads/master@{#33139}
==========

[commit-bot: I haz the power, 2016-01-06 20:26:29]

Patchset 5 (id:??) landed as
https://crrev.com/e62e287237dcd68a60b5a116eebee6425eaa851e
Cr-Commit-Position: refs/heads/master@{#33139}