Chromium Code Reviews
|
|
Chromium Code Reviews|
Created:
5 years ago by aseemgarg Modified:
4 years, 11 months ago Reviewers:
titzer, bradnelson, bradn, ahaas CC:
v8-reviews_googlegroups.com Base URL:
https://chromium.googlesource.com/v8/v8.git@UnreachableNodes Target Ref:
refs/pending/heads/master Project:
v8 Visibility:
Public. |
Descriptionrefactor block loading and unloading
R=bradnelson@chromium.org
BUG=
Committed: https://crrev.com/e62e287237dcd68a60b5a116eebee6425eaa851e
Cr-Commit-Position: refs/heads/master@{#33139}
Patch Set 1 #Patch Set 2 : Refactor block loading/unloading #Patch Set 3 : #
Total comments: 2
Patch Set 4 : #Patch Set 5 : #
Created: 4 years, 11 months ago
Depends on Patchset: Messages
Total messages: 19 (8 generated)
Please don't lgtm and submit. Brad, can you see if this looks like a better pattern to encode dealing with block (I can't go from loops into visitBlock as the types don't match). Also, it seems we'll need to keep block_size_ as is, especially for for loop as it is impossible to know which parts of for loop are null without actually visiting
Brad, you can LGTM now if the other patch looks fine and can be submitted (this depends on that).
bradnelson@google.com changed reviewers: + bradnelson@google.com
lgtm https://codereview.chromium.org/1537743003/diff/40001/src/wasm/asm-wasm-build... File src/wasm/asm-wasm-builder.cc (right): https://codereview.chromium.org/1537743003/diff/40001/src/wasm/asm-wasm-build... src/wasm/asm-wasm-builder.cc:101: class BlockLoader { BlockVisitor ?
aseemgarg@chromium.org changed reviewers: + ahaas@chromium.org
https://codereview.chromium.org/1537743003/diff/40001/src/wasm/asm-wasm-build... File src/wasm/asm-wasm-builder.cc (right): https://codereview.chromium.org/1537743003/diff/40001/src/wasm/asm-wasm-build... src/wasm/asm-wasm-builder.cc:101: class BlockLoader { On 2016/01/04 23:34:13, bradn wrote: > BlockVisitor ? Done.
The CQ bit was checked by aseemgarg@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from bradnelson@google.com Link to the patchset: https://codereview.chromium.org/1537743003/#ps80001 (title: " ")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1537743003/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1537743003/80001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/9463)
aseemgarg@chromium.org changed reviewers: + titzer@chromium.org
LGTM, love it
The CQ bit was checked by aseemgarg@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1537743003/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1537743003/80001
Message was sent while issue was closed.
Committed patchset #5 (id:80001)
Message was sent while issue was closed.
Description was changed from ========== refactor block loading and unloading R=bradnelson@chromium.org BUG= ========== to ========== refactor block loading and unloading R=bradnelson@chromium.org BUG= Committed: https://crrev.com/e62e287237dcd68a60b5a116eebee6425eaa851e Cr-Commit-Position: refs/heads/master@{#33139} ==========
Message was sent while issue was closed.
Patchset 5 (id:??) landed as https://crrev.com/e62e287237dcd68a60b5a116eebee6425eaa851e Cr-Commit-Position: refs/heads/master@{#33139} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
