Add do-while and conditional and mark non asm nodes as unreachable

Add do-while and conditional and mark non asm nodes as unreachable

TEST=asm-wasm.js
R=titzer@chromium.org,bradnelson@chromium.org
BUG=

Add for loop to asm-to-wasm

TEST=asm-wasm.js
R=titzer@chromium.org,bradnelson@google.com

Committed: https://crrev.com/7fdb0da0012c87de668a879b11723382f82ded43
Cr-Commit-Position: refs/heads/master@{#33101}

[aseemgarg, 2015-12-16 00:52:41]

This has both the changes from previous commit - the for loop change and a new
one. Please review the other one https://codereview.chromium.org/1523843003/
first.

[bradnelson, 2015-12-16 13:14:10]

lgtm, sans needing to be merged.

[bradn, 2015-12-16 15:54:17]

https://codereview.chromium.org/1530093002/diff/1/src/wasm/asm-wasm-builder.cc
File src/wasm/asm-wasm-builder.cc (right):

https://codereview.chromium.org/1530093002/diff/1/src/wasm/asm-wasm-builder.c...
src/wasm/asm-wasm-builder.cc:216: block_size_++;
Would it be clearer if we incremented block_size_ in VisitBlock ?

https://codereview.chromium.org/1530093002/diff/1/src/wasm/asm-wasm-builder.c...
src/wasm/asm-wasm-builder.cc:218: block_size_++;
Could we add {} around the whole statement plus the block_size increment to make
it more clear that it's one unit?

https://codereview.chromium.org/1530093002/diff/1/src/wasm/asm-wasm-builder.c...
src/wasm/asm-wasm-builder.cc:254: current_function_builder_->Emit(kExprIf);
Same here?

https://codereview.chromium.org/1530093002/diff/1/src/wasm/asm-wasm-builder.c...
src/wasm/asm-wasm-builder.cc:268: block_size_++;
Same here?

[ahaas, 2015-12-16 15:56:32]

ahaas@chromium.org changed reviewers:
+ ahaas@chromium.org

[ahaas, 2015-12-16 15:56:32]

lgtm

[aseemgarg, 2015-12-19 00:28:39]

Please take a look and LGTM again. Took care of comments in another commit.

https://codereview.chromium.org/1530093002/diff/1/src/wasm/asm-wasm-builder.cc
File src/wasm/asm-wasm-builder.cc (right):

https://codereview.chromium.org/1530093002/diff/1/src/wasm/asm-wasm-builder.c...
src/wasm/asm-wasm-builder.cc:216: block_size_++;
On 2015/12/16 15:54:17, bradn wrote:
> Would it be clearer if we incremented block_size_ in VisitBlock ?

Took care in the next commit. Can't really move to VisitBlock, but refactored
out the common parts to a class.

https://codereview.chromium.org/1530093002/diff/1/src/wasm/asm-wasm-builder.c...
src/wasm/asm-wasm-builder.cc:218: block_size_++;
On 2015/12/16 15:54:17, bradn wrote:
> Could we add {} around the whole statement plus the block_size increment to
make
> it more clear that it's one unit?

Took care in the next commit.

https://codereview.chromium.org/1530093002/diff/1/src/wasm/asm-wasm-builder.c...
src/wasm/asm-wasm-builder.cc:254: current_function_builder_->Emit(kExprIf);
On 2015/12/16 15:54:17, bradn wrote:
> Same here?

Took care in the next commit.

https://codereview.chromium.org/1530093002/diff/1/src/wasm/asm-wasm-builder.c...
src/wasm/asm-wasm-builder.cc:268: block_size_++;
On 2015/12/16 15:54:17, bradn wrote:
> Same here?

Took care in the next commit.

[bradnelson, 2016-01-04 23:21:46]

lgtm

[aseemgarg, 2016-01-04 23:23:17]

The CQ bit was checked by aseemgarg@chromium.org

[aseemgarg, 2016-01-04 23:23:17]

The patchset sent to the CQ was uploaded after l-g-t-m from ahaas@chromium.org
Link to the patchset: https://codereview.chromium.org/1530093002/#ps60001
(title: " ")

[commit-bot: I haz the power, 2016-01-04 23:23:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1530093002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1530093002/60001

[commit-bot: I haz the power, 2016-01-04 23:46:23]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-01-04 23:47:18]

Description was changed from

==========
Add do-while and conditional and mark non asm nodes as unreachable

TEST=asm-wasm.js
R=titzer@chromium.org,bradnelson@chromium.org
BUG=

Add for loop to asm-to-wasm

TEST=asm-wasm.js
R=titzer@chromium.org,bradnelson@google.com
==========

to

==========
Add do-while and conditional and mark non asm nodes as unreachable

TEST=asm-wasm.js
R=titzer@chromium.org,bradnelson@chromium.org
BUG=

Add for loop to asm-to-wasm

TEST=asm-wasm.js
R=titzer@chromium.org,bradnelson@google.com

Committed: https://crrev.com/7fdb0da0012c87de668a879b11723382f82ded43
Cr-Commit-Position: refs/heads/master@{#33101}
==========

[commit-bot: I haz the power, 2016-01-04 23:47:18]

Patchset 4 (id:??) landed as
https://crrev.com/7fdb0da0012c87de668a879b11723382f82ded43
Cr-Commit-Position: refs/heads/master@{#33101}