refactor block loading and unloading

src/wasm/asm-wasm-builder.cc

 // Copyright 2015 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/v8.h"
 
 #include "src/wasm/asm-wasm-builder.h"
 #include "src/wasm/wasm-macro-gen.h"
 #include "src/wasm/wasm-opcodes.h"
 
@@ skipping 74 matching lines @@
       ExpressionStatement* expr =
           stmt->statements()->at(0)->AsExpressionStatement();
       if (expr != NULL) {
         if (expr->expression()->IsAssignment()) {
           RECURSE(VisitExpressionStatement(expr));
           return;
         }
       }
     }
     DCHECK(in_function_);
-    breakable_blocks_.push_back(
-        std::make_pair(stmt->AsBreakableStatement(), false));
-    current_function_builder_->Emit(kExprBlock);
-    uint32_t index = current_function_builder_->EmitEditableImmediate(0);
-    int prev_block_size = block_size_;
+    BlockVisitor visitor(this, stmt->AsBreakableStatement(), kExprBlock, false);
     block_size_ = static_cast<byte>(stmt->statements()->length());
     RECURSE(VisitStatements(stmt->statements()));
     DCHECK(block_size_ >= 0);
-    current_function_builder_->EditImmediate(index, block_size_);
-    block_size_ = prev_block_size;
-    breakable_blocks_.pop_back();
   }
 
+  class BlockVisitor {
+   private:
+    int prev_block_size_;
+    uint32_t index_;
+    AsmWasmBuilderImpl* builder_;
+
+   public:
+    BlockVisitor(AsmWasmBuilderImpl* builder, BreakableStatement* stmt,
+                 WasmOpcode opcode, bool is_loop)
+        : builder_(builder) {
+      builder_->breakable_blocks_.push_back(std::make_pair(stmt, is_loop));
+      builder_->current_function_builder_->Emit(opcode);
+      index_ = builder_->current_function_builder_->EmitEditableImmediate(0);
+      prev_block_size_ = builder_->block_size_;
+    }
+    ~BlockVisitor() {
+      builder_->current_function_builder_->EditImmediate(index_,
+                                                         builder_->block_size_);
+      builder_->block_size_ = prev_block_size_;
+      builder_->breakable_blocks_.pop_back();
+    }
+  };
+
   void VisitExpressionStatement(ExpressionStatement* stmt) {
     RECURSE(Visit(stmt->expression()));
   }
 
   void VisitEmptyStatement(EmptyStatement* stmt) {}
 
   void VisitEmptyParentheses(EmptyParentheses* paren) { UNREACHABLE(); }
 
   void VisitIfStatement(IfStatement* stmt) {
     DCHECK(in_function_);
@@ skipping 82 matching lines @@
       }
       ZoneList<Statement*>* stmts = clause->statements();
       RECURSE(VisitStatements(stmts));
     }
   }
 
   void VisitCaseClause(CaseClause* clause) { UNREACHABLE(); }
 
   void VisitDoWhileStatement(DoWhileStatement* stmt) {
     DCHECK(in_function_);
-    current_function_builder_->Emit(kExprLoop);
-    uint32_t index = current_function_builder_->EmitEditableImmediate(0);
-    int prev_block_size = block_size_;
-    block_size_ = 0;
-    breakable_blocks_.push_back(
-        std::make_pair(stmt->AsBreakableStatement(), true));
-    block_size_++;
+    BlockVisitor visitor(this, stmt->AsBreakableStatement(), kExprLoop, true);
+    block_size_ = 2;
     RECURSE(Visit(stmt->body()));
-    block_size_++;
     current_function_builder_->Emit(kExprIf);
     RECURSE(Visit(stmt->cond()));
     current_function_builder_->EmitWithU8(kExprBr, 0);
     current_function_builder_->Emit(kExprNop);
-    current_function_builder_->EditImmediate(index, block_size_);
-    block_size_ = prev_block_size;
-    breakable_blocks_.pop_back();
   }
 
   void VisitWhileStatement(WhileStatement* stmt) {
     DCHECK(in_function_);
-    current_function_builder_->EmitWithU8(kExprLoop, 1);
-    breakable_blocks_.push_back(
-        std::make_pair(stmt->AsBreakableStatement(), true));
+    BlockVisitor visitor(this, stmt->AsBreakableStatement(), kExprLoop, true);
+    block_size_ = 1;
     current_function_builder_->Emit(kExprIf);
     RECURSE(Visit(stmt->cond()));
     current_function_builder_->EmitWithU8(kExprBr, 0);
     RECURSE(Visit(stmt->body()));
-    breakable_blocks_.pop_back();
   }
 
   void VisitForStatement(ForStatement* stmt) {
     DCHECK(in_function_);
     if (stmt->init() != NULL) {
       block_size_++;
       RECURSE(Visit(stmt->init()));
     }
-    current_function_builder_->Emit(kExprLoop);
-    uint32_t index = current_function_builder_->EmitEditableImmediate(0);
-    int prev_block_size = block_size_;
+    BlockVisitor visitor(this, stmt->AsBreakableStatement(), kExprLoop, true);
     block_size_ = 0;
-    breakable_blocks_.push_back(
-        std::make_pair(stmt->AsBreakableStatement(), true));
     if (stmt->cond() != NULL) {
       block_size_++;
       current_function_builder_->Emit(kExprIf);
       current_function_builder_->Emit(kExprBoolNot);
       RECURSE(Visit(stmt->cond()));
       current_function_builder_->EmitWithU8(kExprBr, 1);
       current_function_builder_->Emit(kExprNop);
     }
     if (stmt->body() != NULL) {
       block_size_++;
       RECURSE(Visit(stmt->body()));
     }
     if (stmt->next() != NULL) {
       block_size_++;
       RECURSE(Visit(stmt->next()));
     }
     block_size_++;
     current_function_builder_->EmitWithU8(kExprBr, 0);
     current_function_builder_->Emit(kExprNop);
-    current_function_builder_->EditImmediate(index, block_size_);
-    block_size_ = prev_block_size;
-    breakable_blocks_.pop_back();
   }
 
   void VisitForInStatement(ForInStatement* stmt) { UNREACHABLE(); }
 
   void VisitForOfStatement(ForOfStatement* stmt) { UNREACHABLE(); }
 
   void VisitTryCatchStatement(TryCatchStatement* stmt) { UNREACHABLE(); }
 
   void VisitTryFinallyStatement(TryFinallyStatement* stmt) { UNREACHABLE(); }
 
@@ skipping 716 matching lines @@
 // that zone in constructor may be thrown away once wasm module is written.
 WasmModuleIndex* AsmWasmBuilder::Run() {
   AsmWasmBuilderImpl impl(isolate_, zone_, literal_);
   impl.Compile();
   WasmModuleWriter* writer = impl.builder_->Build(zone_);
   return writer->WriteTo(zone_);
 }
 }  // namespace wasm
 }  // namespace internal
 }  // namespace v8