Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1537653002: Remove old java-based analyzer from test scripts and status files (Closed)

Created:
5 years ago by Bill Hesse
Modified:
5 years ago
Reviewers:
Søren Gjesse
CC:
reviews_dartlang.org, ricow1, turnidge, rmacnak, Cutch, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Remove old java-based analyzer from test scripts and status files BUG= R=sgjesse@google.com Committed: https://github.com/dart-lang/sdk/commit/648559052704c9afe5372f35da944e1ab35b0cbc

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -1099 lines) Patch
M pkg/pkg.status View 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/tests/service/service.status View 1 chunk +1 line, -1 line 0 comments Download
M runtime/tests/vm/vm.status View 2 chunks +2 lines, -2 lines 0 comments Download
M samples-dev/samples-dev.status View 1 chunk +1 line, -1 line 1 comment Download
D sdk/bin/dartanalyzer_java View 1 chunk +0 lines, -68 lines 0 comments Download
D sdk/bin/dartanalyzer_java.bat View 1 chunk +0 lines, -27 lines 0 comments Download
M tests/README View 1 chunk +1 line, -1 line 0 comments Download
D tests/co19/co19-analyzer.status View 1 chunk +0 lines, -293 lines 0 comments Download
M tests/co19/co19-co19.status View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/corelib/corelib.status View 3 chunks +1 line, -32 lines 0 comments Download
M tests/html/html.status View 1 chunk +1 line, -1 line 0 comments Download
M tests/isolate/isolate.status View 1 chunk +1 line, -1 line 0 comments Download
D tests/language/language_analyzer.status View 1 chunk +0 lines, -611 lines 0 comments Download
M tools/testing/dart/co19_test.dart View 1 chunk +0 lines, -1 line 0 comments Download
M tools/testing/dart/compiler_configuration.dart View 5 chunks +17 lines, -42 lines 0 comments Download
M tools/testing/dart/status_reporter.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/testing/dart/test_options.dart View 3 chunks +3 lines, -5 lines 0 comments Download
M tools/testing/dart/test_runner.dart View 2 chunks +3 lines, -2 lines 0 comments Download
M tools/testing/dart/test_suite.dart View 5 chunks +3 lines, -6 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Bill Hesse
5 years ago (2015-12-17 12:52:29 UTC) #2
Søren Gjesse
LGTM! https://codereview.chromium.org/1537653002/diff/1/samples-dev/samples-dev.status File samples-dev/samples-dev.status (right): https://codereview.chromium.org/1537653002/diff/1/samples-dev/samples-dev.status#newcode31 samples-dev/samples-dev.status:31: [ $compiler == dart2analyzer ] Please remove tab ...
5 years ago (2015-12-17 12:56:04 UTC) #3
Bill Hesse
5 years ago (2015-12-17 13:45:03 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
648559052704c9afe5372f35da944e1ab35b0cbc (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698