Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Unified Diff: tools/testing/dart/test_options.dart

Issue 1537653002: Remove old java-based analyzer from test scripts and status files (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/testing/dart/test_options.dart
diff --git a/tools/testing/dart/test_options.dart b/tools/testing/dart/test_options.dart
index 1113174f7d1e42d9caf51dc92e5e9d093db60b0a..a376f28270f05996f75cfb902a6396c58ff471a6 100644
--- a/tools/testing/dart/test_options.dart
+++ b/tools/testing/dart/test_options.dart
@@ -64,11 +64,10 @@ class TestOptionsParser {
safari, ie9, ie10, ie11, firefox, opera, chromeOnAndroid,
none (compile only)),
- dartanalyzer: Perform static analysis on Dart code by running the analyzer on Java.
- dart2analyzer: Perform static analysis on Dart code by running the analyzer on Dart.
+ dart2analyzer: Perform static analysis on Dart code by running the analyzer
(only valid with the following runtimes: none)''',
['-c', '--compiler'],
- ['none', 'dart2js', 'dartanalyzer', 'dart2analyzer'],
+ ['none', 'dart2js', 'dart2analyzer'],
'none'),
// TODO(antonm): fix the option drt.
new _TestOptionSpecification(
@@ -93,7 +92,7 @@ class TestOptionsParser {
[ff | chrome | safari | ie9 | ie10 | ie11 | opera | chromeOnAndroid]:
Run JavaScript in the specified browser.
- none: No runtime, compile only (for example, used for dartanalyzer static
+ none: No runtime, compile only (for example, used for dart2analyzer static
analysis tests).''',
['-r', '--runtime'],
['vm', 'd8', 'jsshell', 'drt', 'dartium', 'ff', 'firefox',
@@ -642,7 +641,6 @@ Note: currently only implemented for dart2js.''',
'ff', 'chrome', 'safari', 'ie9', 'ie10', 'ie11',
'opera', 'chromeOnAndroid', 'safarimobilesim'];
break;
- case 'dartanalyzer':
case 'dart2analyzer':
validRuntimes = const ['none'];
break;

Powered by Google App Engine
This is Rietveld 408576698