Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(691)

Unified Diff: tools/testing/dart/test_suite.dart

Issue 1537653002: Remove old java-based analyzer from test scripts and status files (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« samples-dev/samples-dev.status ('K') | « tools/testing/dart/test_runner.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/testing/dart/test_suite.dart
diff --git a/tools/testing/dart/test_suite.dart b/tools/testing/dart/test_suite.dart
index b36668c17416ad2c5992bbed4802c2a44c08dc54..bec08a890d6dd68d2815b1c38c92de71e7697809 100644
--- a/tools/testing/dart/test_suite.dart
+++ b/tools/testing/dart/test_suite.dart
@@ -674,7 +674,6 @@ class StandardTestSuite extends TestSuite {
var status_paths = ['$directory/$name.status',
'$directory/.status',
'$directory/${name}_dart2js.status',
- '$directory/${name}_analyzer.status',
'$directory/${name}_analyzer2.status'];
return new StandardTestSuite(configuration,
@@ -1502,7 +1501,6 @@ class StandardTestSuite extends TestSuite {
case 'none':
return 'application/dart';
case 'dart2js':
- case 'dartanalyzer':
case 'dart2analyzer':
return 'text/javascript';
default:
@@ -1551,8 +1549,7 @@ class StandardTestSuite extends TestSuite {
args.add('--no-hints');
}
- if ((configuration["compiler"] == "dartanalyzer" ||
- configuration["compiler"] == "dart2analyzer") &&
+ if (configuration["compiler"] == "dart2analyzer" &&
(filePath.filename.contains("dart2js") ||
filePath.directoryPath.segments().last.contains('html_common'))) {
args.add("--use-dart2js-libraries");
@@ -2247,7 +2244,7 @@ class TestUtils {
if (compiler == "dart2js" && configuration["cps_ir"]) {
args.add("--use-cps-ir");
}
- if (compiler == "dartanalyzer" || compiler == "dart2analyzer") {
+ if (compiler == "dart2analyzer") {
args.add("--show-package-warnings");
args.add("--enable-async");
}
@@ -2277,7 +2274,7 @@ class TestUtils {
const ['d8', 'jsshell'].contains(runtime);
static bool isCommandLineAnalyzer(String compiler) =>
- compiler == 'dartanalyzer' || compiler == 'dart2analyzer';
+ compiler == 'dart2analyzer';
static String buildDir(Map configuration) {
// FIXME(kustermann,ricow): Our code assumes that the returned 'buildDir'
« samples-dev/samples-dev.status ('K') | « tools/testing/dart/test_runner.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698