|
|
Description[Interpreter] Enable TurboFan for Ignition variant tests.
Adds --turbo to the set of flags run with ignition (making the
configuration pure Ignition+TurboFan except for fallbacks to
full-codegen for catch / eval). Also changes the default
--ignition-filter to allow everything, rather than omit everything.
BUG=v8:4280
LOG=N
Committed: https://crrev.com/5b4626ad1994f1400be4099f85b6a2efd3515e3e
Cr-Commit-Position: refs/heads/master@{#33090}
Patch Set 1 : #Patch Set 2 : Rebase and add one more skip #
Depends on Patchset: Dependent Patchsets: Messages
Total messages: 29 (16 generated)
The CQ bit was checked by rmcilroy@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1537433003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1537433003/1
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: v8_mac_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel/builds/13369)
The CQ bit was checked by rmcilroy@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1537433003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1537433003/1
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: v8_linux64_asan_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel/builds/...) v8_linux64_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel/builds/13450) v8_linux_mips64el_compile_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mips64el_compile_r...) v8_mac_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel/builds/13437)
Description was changed from ========== [Interpreter] Add ignition cctest whitelist and add --turbo to flags. Adds an ignition whitelist for cctest. Also adds --turbo to the set of flags run with ignition (making the configuration pure Ignition+TurboFan except for fallbacks to full-codegen for catch / eval). Also changes the default --ignition-filter to allow everything, rather than omit everything. BUG=v8:4280 LOG=N ========== to ========== [Interpreter] Enable TurboFan for Ignition variant tests. Adds --turbo to the set of flags run with ignition (making the configuration pure Ignition+TurboFan except for fallbacks to full-codegen for catch / eval). Also changes the default --ignition-filter to allow everything, rather than omit everything. BUG=v8:4280 LOG=N ==========
Patchset #1 (id:1) has been deleted
The CQ bit was checked by rmcilroy@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1537433003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1537433003/20001
rmcilroy@chromium.org changed reviewers: + machenbach@google.com
Michael, could you please take a look? Also, this might cause some additional flakes on the waterfall, so if you see any please ping me and I'll sort out adding the skips.
machenbach@chromium.org changed reviewers: + machenbach@chromium.org
lgtm
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: v8_linux_dbg on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg/builds/12561)
The CQ bit was checked by rmcilroy@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1537433003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1537433003/40001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by rmcilroy@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from machenbach@chromium.org Link to the patchset: https://codereview.chromium.org/1537433003/#ps40001 (title: "Rebase and add one more skip")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1537433003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1537433003/40001
Message was sent while issue was closed.
Description was changed from ========== [Interpreter] Enable TurboFan for Ignition variant tests. Adds --turbo to the set of flags run with ignition (making the configuration pure Ignition+TurboFan except for fallbacks to full-codegen for catch / eval). Also changes the default --ignition-filter to allow everything, rather than omit everything. BUG=v8:4280 LOG=N ========== to ========== [Interpreter] Enable TurboFan for Ignition variant tests. Adds --turbo to the set of flags run with ignition (making the configuration pure Ignition+TurboFan except for fallbacks to full-codegen for catch / eval). Also changes the default --ignition-filter to allow everything, rather than omit everything. BUG=v8:4280 LOG=N ==========
Message was sent while issue was closed.
Committed patchset #2 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== [Interpreter] Enable TurboFan for Ignition variant tests. Adds --turbo to the set of flags run with ignition (making the configuration pure Ignition+TurboFan except for fallbacks to full-codegen for catch / eval). Also changes the default --ignition-filter to allow everything, rather than omit everything. BUG=v8:4280 LOG=N ========== to ========== [Interpreter] Enable TurboFan for Ignition variant tests. Adds --turbo to the set of flags run with ignition (making the configuration pure Ignition+TurboFan except for fallbacks to full-codegen for catch / eval). Also changes the default --ignition-filter to allow everything, rather than omit everything. BUG=v8:4280 LOG=N Committed: https://crrev.com/5b4626ad1994f1400be4099f85b6a2efd3515e3e Cr-Commit-Position: refs/heads/master@{#33090} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/5b4626ad1994f1400be4099f85b6a2efd3515e3e Cr-Commit-Position: refs/heads/master@{#33090} |