Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Issue 1537433003: [Interpreter] Enable TurboFan for Ignition variant tests. (Closed)

Created:
5 years ago by rmcilroy
Modified:
4 years, 11 months ago
CC:
v8-reviews_googlegroups.com, Michael Hablich
Base URL:
https://chromium.googlesource.com/v8/v8.git@int_deopt_2
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[Interpreter] Enable TurboFan for Ignition variant tests. Adds --turbo to the set of flags run with ignition (making the configuration pure Ignition+TurboFan except for fallbacks to full-codegen for catch / eval). Also changes the default --ignition-filter to allow everything, rather than omit everything. BUG=v8:4280 LOG=N Committed: https://crrev.com/5b4626ad1994f1400be4099f85b6a2efd3515e3e Cr-Commit-Position: refs/heads/master@{#33090}

Patch Set 1 : #

Patch Set 2 : Rebase and add one more skip #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -47 lines) Patch
M src/flag-definitions.h View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/mjsunit.status View 1 12 chunks +70 lines, -42 lines 0 comments Download
M tools/testrunner/local/testsuite.py View 2 chunks +2 lines, -4 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 29 (16 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1537433003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1537433003/1
5 years ago (2015-12-17 12:30:59 UTC) #2
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_mac_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel/builds/13369)
5 years ago (2015-12-17 12:34:38 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1537433003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1537433003/1
5 years ago (2015-12-19 10:26:02 UTC) #6
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_linux64_asan_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel/builds/11683) v8_linux64_rel on ...
5 years ago (2015-12-19 10:26:52 UTC) #8
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1537433003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1537433003/20001
4 years, 11 months ago (2016-01-04 12:09:44 UTC) #12
rmcilroy
Michael, could you please take a look? Also, this might cause some additional flakes on ...
4 years, 11 months ago (2016-01-04 12:10:19 UTC) #14
Michael Achenbach
lgtm
4 years, 11 months ago (2016-01-04 12:22:32 UTC) #16
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_linux_dbg on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg/builds/12561)
4 years, 11 months ago (2016-01-04 12:28:55 UTC) #18
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1537433003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1537433003/40001
4 years, 11 months ago (2016-01-04 16:00:08 UTC) #20
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 11 months ago (2016-01-04 16:47:20 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1537433003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1537433003/40001
4 years, 11 months ago (2016-01-04 17:20:57 UTC) #25
commit-bot: I haz the power
Committed patchset #2 (id:40001)
4 years, 11 months ago (2016-01-04 17:32:37 UTC) #27
commit-bot: I haz the power
4 years, 11 months ago (2016-01-04 17:33:14 UTC) #29
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/5b4626ad1994f1400be4099f85b6a2efd3515e3e
Cr-Commit-Position: refs/heads/master@{#33090}

Powered by Google App Engine
This is Rietveld 408576698