Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(274)

Issue 1553123002: [Interpreter] Fix some issues in the non-x64 InterpreterNotifyDeoptimized builtins. (Closed)

Created:
4 years, 11 months ago by rmcilroy
Modified:
4 years, 11 months ago
Reviewers:
oth
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@int_cctest
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[Interpreter] Fix some issues in the non-x64 InterpreterNotifyDeoptimized builtins. Fix stack push issues on non-x64 platforms for InterpreterNotifyDeoptimized builtins. BUG=v8:4280 LOG=N Committed: https://crrev.com/02072112d14d2960fc730fa5cde6b759c47b61a0 Cr-Commit-Position: refs/heads/master@{#33088}

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -22 lines) Patch
M src/arm/builtins-arm.cc View 1 chunk +1 line, -5 lines 0 comments Download
M src/arm64/builtins-arm64.cc View 2 chunks +1 line, -6 lines 0 comments Download
M src/ia32/builtins-ia32.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/mips/builtins-mips.cc View 1 chunk +1 line, -5 lines 0 comments Download
M src/mips64/builtins-mips64.cc View 1 chunk +1 line, -5 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 16 (7 generated)
rmcilroy
Orion, PTAL, thanks.
4 years, 11 months ago (2016-01-04 15:26:23 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1553123002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1553123002/1
4 years, 11 months ago (2016-01-04 15:26:34 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_linux64_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel/builds/13697) v8_linux_dbg on ...
4 years, 11 months ago (2016-01-04 15:48:35 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1553123002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1553123002/20001
4 years, 11 months ago (2016-01-04 15:59:20 UTC) #8
oth
lgtm
4 years, 11 months ago (2016-01-04 16:08:21 UTC) #9
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 11 months ago (2016-01-04 16:35:46 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1553123002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1553123002/20001
4 years, 11 months ago (2016-01-04 16:37:42 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 11 months ago (2016-01-04 17:09:48 UTC) #14
commit-bot: I haz the power
4 years, 11 months ago (2016-01-04 17:11:02 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/02072112d14d2960fc730fa5cde6b759c47b61a0
Cr-Commit-Position: refs/heads/master@{#33088}

Powered by Google App Engine
This is Rietveld 408576698