Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Issue 1557893002: [Interpreter] Add Ignition whitelist for cctests. (Closed)

Created:
4 years, 11 months ago by rmcilroy
Modified:
4 years, 11 months ago
Reviewers:
Michael Achenbach
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@int_cctest_2
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[Interpreter] Add Ignition whitelist for cctests. Adds an ignition whitelist for cctests. BUG=v8:4280 LOG=N Committed: https://crrev.com/af95a4dd3ef9662b8e311689693f1e47640c38f8 Cr-Commit-Position: refs/heads/master@{#33096}

Patch Set 1 #

Patch Set 2 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+103 lines, -0 lines) Patch
M test/cctest/cctest.status View 1 chunk +103 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 14 (6 generated)
rmcilroy
Michael, could you please take a look, thanks. Also, once this lands, could we enable ...
4 years, 11 months ago (2016-01-04 15:30:04 UTC) #2
Michael Achenbach
lgtm - we can. Also other test suites that are part of the standard v8testing? ...
4 years, 11 months ago (2016-01-04 15:58:48 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1557893002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1557893002/20001
4 years, 11 months ago (2016-01-04 16:13:21 UTC) #5
rmcilroy
On 2016/01/04 15:58:48, Michael Achenbach (OOO) wrote: > lgtm - we can. Great, thanks! > ...
4 years, 11 months ago (2016-01-04 16:13:51 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 11 months ago (2016-01-04 17:15:42 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1557893002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1557893002/20001
4 years, 11 months ago (2016-01-04 20:59:56 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 11 months ago (2016-01-04 21:01:18 UTC) #12
commit-bot: I haz the power
4 years, 11 months ago (2016-01-04 21:01:41 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/af95a4dd3ef9662b8e311689693f1e47640c38f8
Cr-Commit-Position: refs/heads/master@{#33096}

Powered by Google App Engine
This is Rietveld 408576698