Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(585)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1536713004: Revert "Delete the ViewManager and WindowManager services." (Closed)

Created:
5 years ago by viettrungluu
Modified:
5 years ago
Reviewers:
jeffbrown
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Revert "Delete the ViewManager and WindowManager services." This reverts commit d03eeb6d9f59ffd4e44ea890877837d69536cc1e. Reverting unreviewed changes. TBR=jeffbrown@google.com Committed: https://chromium.googlesource.com/external/mojo/+/44a822aa149dcd410170092c848ae54b8737c5b3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25675 lines, -772 lines) Patch
M examples/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
A + examples/embedded_app/BUILD.gn View 1 chunk +7 lines, -7 lines 0 comments Download
A examples/embedded_app/embedded_app.cc View 1 chunk +118 lines, -0 lines 0 comments Download
M mojo/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/dart/packages/mojo_services/BUILD.gn View 1 chunk +61 lines, -58 lines 0 comments Download
A mojo/dart/packages/mojo_services/lib/mojo/animations.mojom.dart View 1 chunk +511 lines, -0 lines 0 comments Download
A mojo/dart/packages/mojo_services/lib/mojo/view_manager.mojom.dart View 1 chunk +4628 lines, -0 lines 0 comments Download
A mojo/dart/packages/mojo_services/lib/mojo/view_manager_constants.mojom.dart View 1 chunk +63 lines, -0 lines 0 comments Download
A + mojo/dart/packages/mojo_services/lib/mojo/window_manager.mojom.dart View 48 chunks +501 lines, -656 lines 0 comments Download
A mojo/dart/packages/mojo_services/lib/mojo/window_manager_internal.mojom.dart View 1 chunk +753 lines, -0 lines 0 comments Download
M mojo/nacl/BUILD.gn View 1 chunk +3 lines, -0 lines 0 comments Download
M mojo/services/mojo_services.gni View 1 chunk +2 lines, -0 lines 0 comments Download
A mojo/services/view_manager/cpp/BUILD.gn View 1 chunk +61 lines, -0 lines 0 comments Download
A + mojo/services/view_manager/cpp/keys.h View 1 chunk +4 lines, -8 lines 0 comments Download
A + mojo/services/view_manager/cpp/keys.cc View 1 chunk +3 lines, -9 lines 0 comments Download
A mojo/services/view_manager/cpp/lib/view.cc View 1 chunk +581 lines, -0 lines 0 comments Download
A mojo/services/view_manager/cpp/lib/view_manager_client_factory.cc View 1 chunk +40 lines, -0 lines 0 comments Download
A mojo/services/view_manager/cpp/lib/view_manager_client_impl.h View 1 chunk +164 lines, -0 lines 0 comments Download
A mojo/services/view_manager/cpp/lib/view_manager_client_impl.cc View 1 chunk +494 lines, -0 lines 0 comments Download
A mojo/services/view_manager/cpp/lib/view_manager_context.cc View 1 chunk +45 lines, -0 lines 0 comments Download
A mojo/services/view_manager/cpp/lib/view_observer.cc View 1 chunk +18 lines, -0 lines 0 comments Download
A mojo/services/view_manager/cpp/lib/view_private.h View 1 chunk +63 lines, -0 lines 0 comments Download
A mojo/services/view_manager/cpp/lib/view_private.cc View 1 chunk +20 lines, -0 lines 0 comments Download
A mojo/services/view_manager/cpp/tests/BUILD.gn View 1 chunk +37 lines, -0 lines 0 comments Download
A + mojo/services/view_manager/cpp/tests/run_all_unittests.cc View 1 chunk +2 lines, -11 lines 0 comments Download
A mojo/services/view_manager/cpp/tests/view_manager_test_suite.h View 1 chunk +27 lines, -0 lines 0 comments Download
A mojo/services/view_manager/cpp/tests/view_manager_test_suite.cc View 1 chunk +33 lines, -0 lines 0 comments Download
A mojo/services/view_manager/cpp/tests/view_unittest.cc View 1 chunk +874 lines, -0 lines 0 comments Download
A mojo/services/view_manager/cpp/types.h View 1 chunk +25 lines, -0 lines 0 comments Download
A mojo/services/view_manager/cpp/util.h View 1 chunk +30 lines, -0 lines 0 comments Download
A mojo/services/view_manager/cpp/view.h View 1 chunk +214 lines, -0 lines 0 comments Download
A mojo/services/view_manager/cpp/view_manager.h View 1 chunk +42 lines, -0 lines 0 comments Download
A mojo/services/view_manager/cpp/view_manager_client_factory.h View 1 chunk +43 lines, -0 lines 0 comments Download
A mojo/services/view_manager/cpp/view_manager_context.h View 1 chunk +46 lines, -0 lines 0 comments Download
A mojo/services/view_manager/cpp/view_manager_delegate.h View 1 chunk +52 lines, -0 lines 0 comments Download
A + mojo/services/view_manager/cpp/view_manager_delegate.cc View 1 chunk +5 lines, -9 lines 0 comments Download
A mojo/services/view_manager/cpp/view_observer.h View 1 chunk +105 lines, -0 lines 0 comments Download
A mojo/services/view_manager/cpp/view_property.h View 1 chunk +139 lines, -0 lines 0 comments Download
A mojo/services/view_manager/cpp/view_tracker.h View 1 chunk +47 lines, -0 lines 0 comments Download
A mojo/services/view_manager/cpp/view_tracker.cc View 1 chunk +40 lines, -0 lines 0 comments Download
A + mojo/services/view_manager/interfaces/BUILD.gn View 1 chunk +7 lines, -3 lines 0 comments Download
A mojo/services/view_manager/interfaces/animations.mojom View 1 chunk +62 lines, -0 lines 0 comments Download
A mojo/services/view_manager/interfaces/view_manager.mojom View 1 chunk +233 lines, -0 lines 0 comments Download
A + mojo/services/view_manager/interfaces/view_manager_constants.mojom View 1 chunk +5 lines, -3 lines 0 comments Download
A + mojo/services/window_manager/interfaces/BUILD.gn View 1 chunk +5 lines, -4 lines 0 comments Download
A mojo/services/window_manager/interfaces/window_manager.mojom View 1 chunk +38 lines, -0 lines 0 comments Download
A mojo/services/window_manager/interfaces/window_manager_internal.mojom View 1 chunk +42 lines, -0 lines 0 comments Download
M services/BUILD.gn View 3 chunks +13 lines, -0 lines 0 comments Download
A services/kiosk_wm/BUILD.gn View 1 chunk +37 lines, -0 lines 0 comments Download
A services/kiosk_wm/README.md View 1 chunk +6 lines, -0 lines 0 comments Download
A services/kiosk_wm/kiosk_wm.h View 1 chunk +44 lines, -0 lines 0 comments Download
A services/kiosk_wm/kiosk_wm.cc View 1 chunk +44 lines, -0 lines 0 comments Download
A services/kiosk_wm/kiosk_wm_controller.h View 1 chunk +84 lines, -0 lines 0 comments Download
A services/kiosk_wm/kiosk_wm_controller.cc View 1 chunk +109 lines, -0 lines 0 comments Download
A + services/kiosk_wm/main.cc View 1 chunk +3 lines, -2 lines 0 comments Download
A services/kiosk_wm/merged_service_provider.h View 1 chunk +41 lines, -0 lines 0 comments Download
A services/kiosk_wm/merged_service_provider.cc View 1 chunk +35 lines, -0 lines 0 comments Download
A services/kiosk_wm/navigator_host_impl.h View 1 chunk +43 lines, -0 lines 0 comments Download
A services/kiosk_wm/navigator_host_impl.cc View 1 chunk +54 lines, -0 lines 0 comments Download
A services/view_manager/BUILD.gn View 1 chunk +196 lines, -0 lines 0 comments Download
A services/view_manager/access_policy.h View 1 chunk +52 lines, -0 lines 0 comments Download
A services/view_manager/access_policy_delegate.h View 1 chunk +36 lines, -0 lines 0 comments Download
A services/view_manager/animation_runner.h View 1 chunk +114 lines, -0 lines 0 comments Download
A services/view_manager/animation_runner.cc View 1 chunk +156 lines, -0 lines 0 comments Download
A services/view_manager/animation_runner_observer.h View 1 chunk +23 lines, -0 lines 0 comments Download
A services/view_manager/animation_runner_unittest.cc View 1 chunk +636 lines, -0 lines 0 comments Download
A services/view_manager/client_connection.h View 1 chunk +57 lines, -0 lines 0 comments Download
A services/view_manager/client_connection.cc View 1 chunk +36 lines, -0 lines 0 comments Download
A services/view_manager/connection_manager.h View 1 chunk +252 lines, -0 lines 0 comments Download
A services/view_manager/connection_manager.cc View 1 chunk +507 lines, -0 lines 0 comments Download
A services/view_manager/connection_manager_delegate.h View 1 chunk +50 lines, -0 lines 0 comments Download
A services/view_manager/default_access_policy.h View 1 chunk +53 lines, -0 lines 0 comments Download
A services/view_manager/default_access_policy.cc View 1 chunk +112 lines, -0 lines 0 comments Download
A services/view_manager/display_manager.h View 1 chunk +91 lines, -0 lines 0 comments Download
A services/view_manager/display_manager.cc View 1 chunk +181 lines, -0 lines 0 comments Download
A services/view_manager/focus_controller.h View 1 chunk +53 lines, -0 lines 0 comments Download
A services/view_manager/focus_controller.cc View 1 chunk +54 lines, -0 lines 0 comments Download
A services/view_manager/focus_controller_delegate.h View 1 chunk +23 lines, -0 lines 0 comments Download
A services/view_manager/focus_controller_unittest.cc View 1 chunk +106 lines, -0 lines 0 comments Download
A services/view_manager/gesture_manager.h View 1 chunk +188 lines, -0 lines 0 comments Download
A services/view_manager/gesture_manager.cc View 1 chunk +701 lines, -0 lines 0 comments Download
A services/view_manager/gesture_manager_delegate.h View 1 chunk +31 lines, -0 lines 0 comments Download
A services/view_manager/gesture_manager_unittest.cc View 1 chunk +467 lines, -0 lines 0 comments Download
A services/view_manager/ids.h View 1 chunk +62 lines, -0 lines 0 comments Download
A + services/view_manager/main.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A services/view_manager/scheduled_animation_group.h View 1 chunk +110 lines, -0 lines 0 comments Download
A services/view_manager/scheduled_animation_group.cc View 1 chunk +348 lines, -0 lines 0 comments Download
A services/view_manager/scheduled_animation_group_unittest.cc View 1 chunk +94 lines, -0 lines 0 comments Download
A services/view_manager/server_view.h View 1 chunk +120 lines, -0 lines 0 comments Download
A services/view_manager/server_view.cc View 1 chunk +234 lines, -0 lines 0 comments Download
A services/view_manager/server_view_delegate.h View 1 chunk +48 lines, -0 lines 0 comments Download
A services/view_manager/server_view_drawn_tracker.h View 1 chunk +58 lines, -0 lines 0 comments Download
A services/view_manager/server_view_drawn_tracker.cc View 1 chunk +76 lines, -0 lines 0 comments Download
A services/view_manager/server_view_drawn_tracker_observer.h View 1 chunk +28 lines, -0 lines 0 comments Download
A services/view_manager/server_view_drawn_tracker_unittest.cc View 1 chunk +136 lines, -0 lines 0 comments Download
A services/view_manager/server_view_observer.h View 1 chunk +63 lines, -0 lines 0 comments Download
A services/view_manager/test_change_tracker.h View 1 chunk +157 lines, -0 lines 0 comments Download
A services/view_manager/test_change_tracker.cc View 1 chunk +314 lines, -0 lines 0 comments Download
A services/view_manager/test_server_view_delegate.h View 1 chunk +32 lines, -0 lines 0 comments Download
A services/view_manager/test_server_view_delegate.cc View 1 chunk +30 lines, -0 lines 0 comments Download
A services/view_manager/view_coordinate_conversions.h View 1 chunk +35 lines, -0 lines 0 comments Download
A services/view_manager/view_coordinate_conversions.cc View 1 chunk +69 lines, -0 lines 0 comments Download
A services/view_manager/view_coordinate_conversions_unittest.cc View 1 chunk +58 lines, -0 lines 0 comments Download
A services/view_manager/view_locator.h View 1 chunk +24 lines, -0 lines 0 comments Download
A services/view_manager/view_locator.cc View 1 chunk +35 lines, -0 lines 0 comments Download
A services/view_manager/view_manager_app.h View 1 chunk +41 lines, -0 lines 0 comments Download
A services/view_manager/view_manager_app.cc View 1 chunk +58 lines, -0 lines 0 comments Download
A services/view_manager/view_manager_client_apptest.cc View 1 chunk +653 lines, -0 lines 0 comments Download
A services/view_manager/view_manager_root_connection.h View 1 chunk +91 lines, -0 lines 0 comments Download
A services/view_manager/view_manager_root_connection.cc View 1 chunk +139 lines, -0 lines 0 comments Download
A services/view_manager/view_manager_service_apptest.cc View 1 chunk +1496 lines, -0 lines 0 comments Download
A services/view_manager/view_manager_service_impl.h View 1 chunk +260 lines, -0 lines 0 comments Download
A services/view_manager/view_manager_service_impl.cc View 1 chunk +656 lines, -0 lines 0 comments Download
A services/view_manager/view_manager_service_unittest.cc View 1 chunk +471 lines, -0 lines 0 comments Download
A services/view_manager/window_manager_access_policy.h View 1 chunk +52 lines, -0 lines 0 comments Download
A services/view_manager/window_manager_access_policy.cc View 1 chunk +97 lines, -0 lines 0 comments Download
A services/window_manager/BUILD.gn View 1 chunk +130 lines, -0 lines 0 comments Download
A services/window_manager/basic_focus_rules.h View 1 chunk +49 lines, -0 lines 0 comments Download
A services/window_manager/basic_focus_rules.cc View 1 chunk +171 lines, -0 lines 0 comments Download
A services/window_manager/capture_controller.h View 1 chunk +49 lines, -0 lines 0 comments Download
A services/window_manager/capture_controller.cc View 1 chunk +103 lines, -0 lines 0 comments Download
A services/window_manager/capture_controller_observer.h View 1 chunk +20 lines, -0 lines 0 comments Download
A services/window_manager/focus_controller.h View 1 chunk +102 lines, -0 lines 0 comments Download
A services/window_manager/focus_controller.cc View 1 chunk +317 lines, -0 lines 0 comments Download
A services/window_manager/focus_controller_observer.h View 1 chunk +35 lines, -0 lines 0 comments Download
A services/window_manager/focus_controller_unittest.cc View 1 chunk +1197 lines, -0 lines 0 comments Download
A services/window_manager/focus_rules.h View 1 chunk +65 lines, -0 lines 0 comments Download
A services/window_manager/hit_test.h View 1 chunk +41 lines, -0 lines 0 comments Download
A services/window_manager/main.cc View 1 chunk +108 lines, -0 lines 0 comments Download
A services/window_manager/native_viewport_event_dispatcher_impl.h View 1 chunk +42 lines, -0 lines 0 comments Download
A services/window_manager/native_viewport_event_dispatcher_impl.cc View 1 chunk +37 lines, -0 lines 0 comments Download
A services/window_manager/run_all_unittests.cc View 1 chunk +43 lines, -0 lines 0 comments Download
A services/window_manager/view_event_dispatcher.h View 1 chunk +47 lines, -0 lines 0 comments Download
A services/window_manager/view_event_dispatcher.cc View 1 chunk +55 lines, -0 lines 0 comments Download
A services/window_manager/view_target.h View 1 chunk +100 lines, -0 lines 0 comments Download
A services/window_manager/view_target.cc View 1 chunk +167 lines, -0 lines 0 comments Download
A services/window_manager/view_target_unittest.cc View 1 chunk +81 lines, -0 lines 0 comments Download
A services/window_manager/view_targeter.h View 1 chunk +50 lines, -0 lines 0 comments Download
A services/window_manager/view_targeter.cc View 1 chunk +148 lines, -0 lines 0 comments Download
A services/window_manager/view_targeter_unittest.cc View 1 chunk +114 lines, -0 lines 0 comments Download
A services/window_manager/window_manager_app.h View 1 chunk +51 lines, -0 lines 0 comments Download
A services/window_manager/window_manager_app.cc View 1 chunk +64 lines, -0 lines 0 comments Download
A services/window_manager/window_manager_apptest.cc View 1 chunk +212 lines, -0 lines 0 comments Download
A services/window_manager/window_manager_delegate.h View 1 chunk +54 lines, -0 lines 0 comments Download
A services/window_manager/window_manager_impl.h View 1 chunk +63 lines, -0 lines 0 comments Download
A services/window_manager/window_manager_impl.cc View 1 chunk +94 lines, -0 lines 0 comments Download
A services/window_manager/window_manager_root.h View 1 chunk +200 lines, -0 lines 0 comments Download
A services/window_manager/window_manager_root.cc View 1 chunk +413 lines, -0 lines 0 comments Download
A services/window_manager/window_manager_root_android.cc View 1 chunk +20 lines, -0 lines 0 comments Download
A services/window_manager/window_manager_root_linux.cc View 1 chunk +14 lines, -0 lines 0 comments Download
A services/window_manager/window_manager_test_util.h View 1 chunk +43 lines, -0 lines 0 comments Download
A services/window_manager/window_manager_test_util.cc View 1 chunk +39 lines, -0 lines 0 comments Download
M shell/BUILD.gn View 3 chunks +5 lines, -0 lines 0 comments Download
M shell/android/main.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
viettrungluu
5 years ago (2015-12-17 21:26:32 UTC) #2
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
44a822aa149dcd410170092c848ae54b8737c5b3.

Powered by Google App Engine
This is Rietveld 408576698