Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(307)

Issue 1536113003: Oilpan: prefinalize StyleFetchedImage* image resource clients. (Closed)

Created:
5 years ago by sof
Modified:
5 years ago
Reviewers:
haraken
CC:
chromium-reviews, blink-reviews, blink-reviews-style_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Oilpan: prefinalize StyleFetchedImage* image resource clients. Followup r366092 and switch finalization mechanism for StyleFetchedImage and StyleFetchedImageSet to prefinalizers. Having them be eagerly finalized conflicted in some cases with another eagerly finalized object (a FrameView scrollable area), as these StyleFetchedImage objects cannot be allowed to touch another eagerly finalized object. Avoid the finalization (non-)ordering issue by switching these to prefinalized objects instead. R=haraken BUG= Committed: https://crrev.com/902168ab29228b90c7cb8bc964af4001402d0dbc Cr-Commit-Position: refs/heads/master@{#366275}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -11 lines) Patch
M third_party/WebKit/Source/core/style/StyleFetchedImage.h View 2 chunks +3 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/style/StyleFetchedImage.cpp View 1 chunk +10 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/style/StyleFetchedImageSet.h View 2 chunks +3 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/style/StyleFetchedImageSet.cpp View 1 chunk +10 lines, -1 line 0 comments Download

Messages

Total messages: 9 (5 generated)
haraken
LGTM
5 years ago (2015-12-19 04:10:19 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1536113003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1536113003/1
5 years ago (2015-12-19 06:57:47 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-19 07:43:56 UTC) #7
commit-bot: I haz the power
5 years ago (2015-12-19 07:45:03 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/902168ab29228b90c7cb8bc964af4001402d0dbc
Cr-Commit-Position: refs/heads/master@{#366275}

Powered by Google App Engine
This is Rietveld 408576698