Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(753)

Unified Diff: third_party/WebKit/Source/core/style/StyleFetchedImage.h

Issue 1536113003: Oilpan: prefinalize StyleFetchedImage* image resource clients. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/style/StyleFetchedImage.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/style/StyleFetchedImage.h
diff --git a/third_party/WebKit/Source/core/style/StyleFetchedImage.h b/third_party/WebKit/Source/core/style/StyleFetchedImage.h
index 7924be82aa9a75dcd5749a59562d803cc13d3e85..0e891d4ab1a8957dbd21c732c7293b390d1ce508 100644
--- a/third_party/WebKit/Source/core/style/StyleFetchedImage.h
+++ b/third_party/WebKit/Source/core/style/StyleFetchedImage.h
@@ -35,6 +35,7 @@ class ImageResource;
class StyleFetchedImage final : public StyleImage, private ImageResourceClient {
USING_FAST_MALLOC_WILL_BE_REMOVED(StyleFetchedImage);
+ WILL_BE_USING_PRE_FINALIZER(StyleFetchedImage, dispose);
public:
static PassRefPtrWillBeRawPtr<StyleFetchedImage> create(ImageResource* image, Document* document, const KURL& url)
{
@@ -63,16 +64,13 @@ public:
bool knownToBeOpaque(const LayoutObject*) const override;
ImageResource* cachedImage() const override;
-#if ENABLE(OILPAN)
- // Promptly remove as a ImageResource client.
- EAGERLY_FINALIZE();
- DECLARE_EAGER_FINALIZATION_OPERATOR_NEW();
-#endif
DECLARE_VIRTUAL_TRACE();
private:
StyleFetchedImage(ImageResource*, Document*, const KURL&);
+ void dispose();
+
ResourcePtr<ImageResource> m_image;
RawPtrWillBeMember<Document> m_document;
const KURL m_url;
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/style/StyleFetchedImage.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698