Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(266)

Unified Diff: third_party/WebKit/Source/core/style/StyleFetchedImageSet.h

Issue 1536113003: Oilpan: prefinalize StyleFetchedImage* image resource clients. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/style/StyleFetchedImageSet.h
diff --git a/third_party/WebKit/Source/core/style/StyleFetchedImageSet.h b/third_party/WebKit/Source/core/style/StyleFetchedImageSet.h
index d2270396b59aaf2811f7fbc4c8fe394a3e9d9596..2eb58d1f815eba6855570a9abb5613aa9232d6dd 100644
--- a/third_party/WebKit/Source/core/style/StyleFetchedImageSet.h
+++ b/third_party/WebKit/Source/core/style/StyleFetchedImageSet.h
@@ -40,6 +40,7 @@ class CSSImageSetValue;
class StyleFetchedImageSet final : public StyleImage, private ImageResourceClient {
USING_FAST_MALLOC_WILL_BE_REMOVED(StyleFetchedImageSet);
+ WILL_BE_USING_PRE_FINALIZER(StyleFetchedImageSet, dispose);
public:
static PassRefPtrWillBeRawPtr<StyleFetchedImageSet> create(ImageResource* image, float imageScaleFactor, CSSImageSetValue* value, const KURL& url)
{
@@ -74,16 +75,13 @@ public:
bool knownToBeOpaque(const LayoutObject*) const override;
ImageResource* cachedImage() const override;
-#if ENABLE(OILPAN)
- // Promptly remove as a ImageResource client.
- EAGERLY_FINALIZE();
- DECLARE_EAGER_FINALIZATION_OPERATOR_NEW();
-#endif
DECLARE_VIRTUAL_TRACE();
private:
StyleFetchedImageSet(ImageResource*, float imageScaleFactor, CSSImageSetValue*, const KURL&);
+ void dispose();
+
String debugName() const override { return "StyleFetchedImageSet"; }
ResourcePtr<ImageResource> m_bestFitImage;

Powered by Google App Engine
This is Rietveld 408576698