Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(382)

Issue 1535863002: Only set -rpath=$ORIGIN in component builds by default. (Closed)

Created:
5 years ago by brettw
Modified:
5 years ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2564
Target Ref:
refs/pending/branch-heads/2564
Project:
chromium
Visibility:
Public.

Description

Only set -rpath=$ORIGIN in component builds by default. Statically-linked binaries do not need -rpath=$ORIGIN set, and setting it can be a source of strange security issues (see bug for more details). Manually add this to some test binaries that require shared libraries to be loaded from the build directory. R=phajdan.jr@chromium.org, thestig@chromium.org BUG=556843 Renald of https://codereview.chromium.org/1525733002/ TBR=dpranke@chromium.org Review URL: https://codereview.chromium.org/1525773002 Cr-Commit-Position: refs/heads/master@{#365125} (cherry picked from commit 5e6333017764d72b4a9edefb12a5409340e9a33a) Committed: https://chromium.googlesource.com/chromium/src/+/f85263d713f004df69e8ac2375f3909c490dc4c8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+98 lines, -8 lines) Patch
M base/BUILD.gn View 1 chunk +6 lines, -0 lines 0 comments Download
M build/config/gcc/BUILD.gn View 2 chunks +44 lines, -8 lines 0 comments Download
M chrome/test/BUILD.gn View 1 chunk +6 lines, -0 lines 0 comments Download
M mojo/common/BUILD.gn View 1 chunk +6 lines, -0 lines 0 comments Download
M third_party/mojo/src/mojo/edk/test/BUILD.gn View 6 chunks +36 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
brettw
Committed patchset #1 (id:1) manually as f85263d713f004df69e8ac2375f3909c490dc4c8.
5 years ago (2015-12-17 23:05:10 UTC) #2
Dirk Pranke
5 years ago (2015-12-18 03:03:31 UTC) #3
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698