Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(413)

Issue 1525773002: Only set -rpath=$ORIGIN in component builds by default. (Closed)

Created:
5 years ago by brettw
Modified:
5 years ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews, qsr+mojo_chromium.org, vmpstr+watch_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, cc-bugs_chromium.org, ben+mojo_chromium.org, darin (slow to review)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Only set -rpath=$ORIGIN in component builds by default. Statically-linked binaries do not need -rpath=$ORIGIN set, and setting it can be a source of strange security issues (see bug for more details). Manually add this to some test binaries that require shared libraries to be loaded from the build directory. R=phajdan.jr@chromium.org, thestig@chromium.org BUG=556843 Renald of https://codereview.chromium.org/1525733002/ TBR=dpranke@chromium.org Committed: https://crrev.com/5e6333017764d72b4a9edefb12a5409340e9a33a Cr-Commit-Position: refs/heads/master@{#365125}

Patch Set 1 #

Patch Set 2 : is_linux #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+99 lines, -9 lines) Patch
M base/BUILD.gn View 1 chunk +6 lines, -0 lines 0 comments Download
M build/config/gcc/BUILD.gn View 2 chunks +44 lines, -8 lines 0 comments Download
M chrome/test/BUILD.gn View 1 chunk +6 lines, -0 lines 0 comments Download
M mojo/common/BUILD.gn View 1 chunk +6 lines, -0 lines 0 comments Download
M ppapi/BUILD.gn View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/mojo/src/mojo/edk/test/BUILD.gn View 6 chunks +36 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 13 (8 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1525773002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1525773002/1
5 years ago (2015-12-14 20:40:41 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1525773002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1525773002/20001
5 years ago (2015-12-14 20:52:39 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1525773002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1525773002/40001
5 years ago (2015-12-14 21:08:39 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years ago (2015-12-14 23:26:02 UTC) #11
commit-bot: I haz the power
5 years ago (2015-12-14 23:27:04 UTC) #13
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/5e6333017764d72b4a9edefb12a5409340e9a33a
Cr-Commit-Position: refs/heads/master@{#365125}

Powered by Google App Engine
This is Rietveld 408576698