Move config table to GrGLCaps from GrGLGpu.

Move config table to GrGLCaps from GrGLGpu.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1535153002

Committed: https://skia.googlesource.com/skia/+/304473749db1ee877addb3ddf090d2e36ede2c2a

[bsalomon, 2015-12-18 15:45:25]

Description was changed from

==========
Move config table to GrGLCaps from GrGLGpu.

BUG=skia:
==========

to

==========
Move config table to GrGLCaps from GrGLGpu.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[bsalomon, 2015-12-18 16:15:42]

https://codereview.chromium.org/1535153002/diff/20001/src/gpu/gl/GrGLCaps.cpp
File src/gpu/gl/GrGLCaps.cpp (right):

https://codereview.chromium.org/1535153002/diff/20001/src/gpu/gl/GrGLCaps.cpp...
src/gpu/gl/GrGLCaps.cpp:1350: void GrGLCaps::initConfigTable(const
GrGLContextInfo& ctxInfo) {
This is purely a mechanical transfer from GrGLGpu with some line wrapping due to
insertion of .fFormats everywhere.

[bsalomon, 2015-12-21 14:58:27]

bsalomon@google.com changed reviewers:
+ egdaniel@google.com

[bsalomon, 2015-12-21 14:58:27]

I sent this to the void last week. +Greg.

[egdaniel, 2015-12-21 15:10:45]

https://codereview.chromium.org/1535153002/diff/40001/src/gpu/gl/GrGLCaps.h
File src/gpu/gl/GrGLCaps.h (right):

https://codereview.chromium.org/1535153002/diff/40001/src/gpu/gl/GrGLCaps.h#n...
src/gpu/gl/GrGLCaps.h:160: *index = fConfigTable[config].fStencilFormatIndex;
is it worth asserting that index > 0 here. Thus we know index is either a valid
value or unsupported.

https://codereview.chromium.org/1535153002/diff/40001/src/gpu/gl/GrGLGpu.cpp
File src/gpu/gl/GrGLGpu.cpp (right):

https://codereview.chromium.org/1535153002/diff/40001/src/gpu/gl/GrGLGpu.cpp#...
src/gpu/gl/GrGLGpu.cpp:700: GrGLenum externalFormat =
this->glCaps().configGLFormats(desc.fConfig).fExternalFormatForTexImage;
100 chars, maybe save the ConfigFormat for all these calls

https://codereview.chromium.org/1535153002/diff/40001/src/gpu/gl/GrGLGpu.cpp#...
src/gpu/gl/GrGLGpu.cpp:1296: return
this->glCaps().getStencilFormatIndexForConfig(config, &index) ? index : -1;
This seems strange to have getStencilFIFC return a bool only to return -1 here.
Does it make more sense for getStencilFIFC to simply return kUnsupported (since
we assert that it is not unknown in call).

[bsalomon, 2015-12-21 15:59:44]

https://codereview.chromium.org/1535153002/diff/40001/src/gpu/gl/GrGLCaps.h
File src/gpu/gl/GrGLCaps.h (right):

https://codereview.chromium.org/1535153002/diff/40001/src/gpu/gl/GrGLCaps.h#n...
src/gpu/gl/GrGLCaps.h:160: *index = fConfigTable[config].fStencilFormatIndex;
On 2015/12/21 15:10:44, egdaniel wrote:
> is it worth asserting that index > 0 here. Thus we know index is either a
valid
> value or unsupported.
Took your other suggestion to just return an int here rather than a bool

https://codereview.chromium.org/1535153002/diff/40001/src/gpu/gl/GrGLGpu.cpp
File src/gpu/gl/GrGLGpu.cpp (right):

https://codereview.chromium.org/1535153002/diff/40001/src/gpu/gl/GrGLGpu.cpp#...
src/gpu/gl/GrGLGpu.cpp:700: GrGLenum externalFormat =
this->glCaps().configGLFormats(desc.fConfig).fExternalFormatForTexImage;
On 2015/12/21 15:10:44, egdaniel wrote:
> 100 chars, maybe save the ConfigFormat for all these calls
Actually there is a worse issue here: the second two are supposed to use
dataConfig not desc.fConfig, fixed that (and wrapped the lines).

https://codereview.chromium.org/1535153002/diff/40001/src/gpu/gl/GrGLGpu.cpp#...
src/gpu/gl/GrGLGpu.cpp:1296: return
this->glCaps().getStencilFormatIndexForConfig(config, &index) ? index : -1;
On 2015/12/21 15:10:45, egdaniel wrote:
> This seems strange to have getStencilFIFC return a bool only to return -1
here.
> Does it make more sense for getStencilFIFC to simply return kUnsupported
(since
> we assert that it is not unknown in call).

Agreed it's weird. Done.

[egdaniel, 2015-12-21 16:45:48]

lgtm

[bsalomon, 2015-12-21 16:48:20]

The CQ bit was checked by bsalomon@google.com

[commit-bot: I haz the power, 2015-12-21 16:48:28]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1535153002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1535153002/60001

[commit-bot: I haz the power, 2015-12-21 17:03:08]

Description was changed from

==========
Move config table to GrGLCaps from GrGLGpu.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Move config table to GrGLCaps from GrGLGpu.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/304473749db1ee877addb3ddf090d2e36ede2c2a
==========

[commit-bot: I haz the power, 2015-12-21 17:03:08]

Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/304473749db1ee877addb3ddf090d2e36ede2c2a