Remove GrGLGpu::configToGLFormats

Remove GrGLGpu::configToGLFormats
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1533903004

Committed: https://skia.googlesource.com/skia/+/a11e5fce33f8d6f38c3324d639ca76ddf12598ba

[bsalomon, 2015-12-18 02:04:34]

Description was changed from

==========
Remove GrGLGpu::configToGLFormats
==========

to

==========
Remove GrGLGpu::configToGLFormats
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[bsalomon, 2015-12-18 02:07:37]

bsalomon@google.com changed reviewers:
+ egdaniel@google.com, jvanverth@google.com

[bsalomon, 2015-12-18 02:07:38]

I thought I'd be creating a fInternalRenderbufferFormat field in ConfigEntry,
but it doesn't really seem necessary since the current rule has no exceptions
(and possibly could be removed by always using sized formats).

[bsalomon, 2015-12-18 14:29:36]

The CQ bit was checked by bsalomon@google.com

[commit-bot: I haz the power, 2015-12-18 14:29:47]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1533903004/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1533903004/1

[commit-bot: I haz the power, 2015-12-18 14:29:47]

Note for Reviewers:
The CQ is waiting for an approval.
If you believe that the CL is not ready yet, or if you would like to L-G-T-M
with comments then please uncheck the CQ checkbox.

Waiting for LGTM from valid reviewer(s) till 2015-12-18 20:29 UTC

[commit-bot: I haz the power, 2015-12-18 14:30:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-18 14:30:55]

Try jobs failed on following builders:
  Build-Mac10.8-Clang-x86_64-Release-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Mac10.8-Clang-...)
  Build-Ubuntu-Clang-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-Clang-x...)
  Build-Ubuntu-GCC-Arm64-Debug-Android-Trybot on client.skia.compile
(JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-Arm...)
  Build-Ubuntu-GCC-Arm7-Debug-Android-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-Arm...)
  Build-Ubuntu-GCC-Mips-Debug-Android-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-Mip...)
  Build-Ubuntu-GCC-x86_64-Release-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-x86...)

[jvanverth1, 2015-12-18 15:20:43]

lgtm + comment

https://codereview.chromium.org/1533903004/diff/1/src/gpu/gl/GrGLGpu.cpp
File src/gpu/gl/GrGLGpu.cpp (right):

https://codereview.chromium.org/1533903004/diff/1/src/gpu/gl/GrGLGpu.cpp#newc...
src/gpu/gl/GrGLGpu.cpp:925: GrGLenum colorRenderbufferFormat = 0; // suppress
warning
Putting this back where it was will fix the compile error.

[bsalomon, 2015-12-18 15:25:27]

https://codereview.chromium.org/1533903004/diff/1/src/gpu/gl/GrGLGpu.cpp
File src/gpu/gl/GrGLGpu.cpp (right):

https://codereview.chromium.org/1533903004/diff/1/src/gpu/gl/GrGLGpu.cpp#newc...
src/gpu/gl/GrGLGpu.cpp:925: GrGLenum colorRenderbufferFormat = 0; // suppress
warning
On 2015/12/18 15:20:43, jvanverth1 wrote:
> Putting this back where it was will fix the compile error.

ah.. windows doesn't mind the goto past this init.

[bsalomon, 2015-12-18 15:31:55]

The CQ bit was checked by bsalomon@google.com

[bsalomon, 2015-12-18 15:31:55]

The patchset sent to the CQ was uploaded after l-g-t-m from jvanverth@google.com
Link to the patchset: https://codereview.chromium.org/1533903004/#ps20001
(title: "fix compile error")

[commit-bot: I haz the power, 2015-12-18 15:31:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1533903004/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1533903004/20001

[commit-bot: I haz the power, 2015-12-18 15:59:45]

Description was changed from

==========
Remove GrGLGpu::configToGLFormats
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Remove GrGLGpu::configToGLFormats
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/a11e5fce33f8d6f38c3324d639ca76ddf12598ba
==========

[commit-bot: I haz the power, 2015-12-18 15:59:46]

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/a11e5fce33f8d6f38c3324d639ca76ddf12598ba