Ensure input connection to be created on pressing next button

Ensure input connection to be created on pressing next button

We have recently introduced a logic to return null input connection in
View#onCreateInputConnection() to handle the physical keyboard case
better. (https://codereview.chromium.org/1362603002)

However, when the user is focused on a EditText and jumps to WebView using
'next' button on an input method, then the user cannot type a character
because a real input connection was never created.

WebView cannot distinguish the following two cases:
- Gaining focus with autofocus=true (for which we intentionally do not show
  keyboard)
- Gaining focus through 'next' button

Before that CL, we were simply creating NONE type input connection at the
beginning even when input form was not focused, which caused the original
physical keyboard issue.

In this CL, we will keep an input connection *whenever* currently focused
node is editable, regardless of showIme value.

Some tests should change accordingly: now input connection may not be null
even when keyboard remains hidden.

Also I'm adding a WebView test to prevent a regression.

BUG=569556
Committed: https://crrev.com/945f5e295dbf508e8dbd6a6ab86a6459bda59637
Cr-Commit-Position: refs/heads/master@{#366583}

[Changwan Ryu, 2015-12-18 06:52:29]

changwan@chromium.org changed reviewers:
+ aelias@chromium.org, sgurun@chromium.org

[aelias_OOO_until_Jul13, 2015-12-19 20:32:46]

lgtm

[sgurun-gerrit only, 2015-12-21 23:53:02]

On 2015/12/19 20:32:46, aelias wrote:
> lgtm

lgtm

[Changwan Ryu, 2015-12-22 08:33:49]

The CQ bit was checked by changwan@chromium.org

[Changwan Ryu, 2015-12-22 08:33:49]

The patchset sent to the CQ was uploaded after l-g-t-m from aelias@chromium.org
Link to the patchset: https://codereview.chromium.org/1534163002/#ps20001
(title: " ")

[commit-bot: I haz the power, 2015-12-22 08:33:55]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1534163002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1534163002/20001

[commit-bot: I haz the power, 2015-12-22 09:49:19]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-12-22 09:50:19]

Description was changed from

==========
Ensure input connection to be created on pressing next button

We have recently introduced a logic to return null input connection in
View#onCreateInputConnection() to handle the physical keyboard case
better. (https://codereview.chromium.org/1362603002)

However, when the user is focused on a EditText and jumps to WebView using
'next' button on an input method, then the user cannot type a character
because a real input connection was never created.

WebView cannot distinguish the following two cases:
- Gaining focus with autofocus=true (for which we intentionally do not show
  keyboard)
- Gaining focus through 'next' button

Before that CL, we were simply creating NONE type input connection at the
beginning even when input form was not focused, which caused the original
physical keyboard issue.

In this CL, we will keep an input connection *whenever* currently focused
node is editable, regardless of showIme value.

Some tests should change accordingly: now input connection may not be null
even when keyboard remains hidden.

Also I'm adding a WebView test to prevent a regression.

BUG=569556
==========

to

==========
Ensure input connection to be created on pressing next button

We have recently introduced a logic to return null input connection in
View#onCreateInputConnection() to handle the physical keyboard case
better. (https://codereview.chromium.org/1362603002)

However, when the user is focused on a EditText and jumps to WebView using
'next' button on an input method, then the user cannot type a character
because a real input connection was never created.

WebView cannot distinguish the following two cases:
- Gaining focus with autofocus=true (for which we intentionally do not show
  keyboard)
- Gaining focus through 'next' button

Before that CL, we were simply creating NONE type input connection at the
beginning even when input form was not focused, which caused the original
physical keyboard issue.

In this CL, we will keep an input connection *whenever* currently focused
node is editable, regardless of showIme value.

Some tests should change accordingly: now input connection may not be null
even when keyboard remains hidden.

Also I'm adding a WebView test to prevent a regression.

BUG=569556

Committed: https://crrev.com/945f5e295dbf508e8dbd6a6ab86a6459bda59637
Cr-Commit-Position: refs/heads/master@{#366583}
==========

[commit-bot: I haz the power, 2015-12-22 09:50:20]

Patchset 2 (id:??) landed as
https://crrev.com/945f5e295dbf508e8dbd6a6ab86a6459bda59637
Cr-Commit-Position: refs/heads/master@{#366583}