Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1798)

Unified Diff: content/public/android/java/src/org/chromium/content/browser/input/ImeAdapter.java

Issue 1534163002: Ensure input connection to be created on pressing next button (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/android/java/src/org/chromium/content/browser/input/ImeAdapter.java
diff --git a/content/public/android/java/src/org/chromium/content/browser/input/ImeAdapter.java b/content/public/android/java/src/org/chromium/content/browser/input/ImeAdapter.java
index 44f5f5e7c101083e912f9fb6f26605e77dd41467..bdfd5872f4cd8d402ed40a6215e1336556d701a1 100644
--- a/content/public/android/java/src/org/chromium/content/browser/input/ImeAdapter.java
+++ b/content/public/android/java/src/org/chromium/content/browser/input/ImeAdapter.java
@@ -142,6 +142,7 @@ public class ImeAdapter {
// ImeAdapter#dispatchKeyEvent().
if (mTextInputType == TextInputType.NONE) {
mInputConnection = null;
+ Log.d(TAG, "onCreateInputConnection returns null.");
return null;
}
@@ -155,6 +156,7 @@ public class ImeAdapter {
int initialSelEnd = outAttrs.initialSelEnd = Selection.getSelectionEnd(mEditable);
mInputConnection = mInputConnectionFactory.get(
mViewEmbedder.getAttachedView(), this, initialSelStart, initialSelEnd, outAttrs);
+ Log.d(TAG, "onCreateInputConnection");
return mInputConnection;
}
@@ -242,12 +244,6 @@ public class ImeAdapter {
int textInputFlags, boolean showIfNeeded) {
Log.d(TAG, "updateKeyboardVisibility: type [%d->%d], flags [%d], show [%b], ",
mTextInputType, textInputType, textInputFlags, showIfNeeded);
- // If current input type is none and showIfNeeded is false, IME should not be shown
- // and input type should remain as none.
- if (mTextInputType == TextInputType.NONE && !showIfNeeded) {
- return;
- }
-
mTextInputFlags = textInputFlags;
if (mTextInputType != textInputType) {
mTextInputType = textInputType;

Powered by Google App Engine
This is Rietveld 408576698