Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Unified Diff: content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java

Issue 1534163002: Ensure input connection to be created on pressing next button (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/public/android/java/src/org/chromium/content/browser/input/ImeAdapter.java ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java
diff --git a/content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java b/content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java
index 99686a4c8733c6956abff7939193703c8939acc7..de64517387b2238faeb9c11db52d0d6e4cb3ecdf 100644
--- a/content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java
+++ b/content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java
@@ -978,9 +978,11 @@ public class ImeTest extends ContentShellTestBase {
CriteriaHelper.pollForUIThreadCriteria(new Criteria() {
@Override
public boolean isSatisfied() {
- boolean hasConnection = getAdapterInputConnection() != null;
- return show == mInputMethodManagerWrapper.isShowWithoutHideOutstanding()
- && show == hasConnection;
+ // We do not check the other way around: in some cases we need to keep
+ // input connection even when the last known status is 'hidden'.
+ // See crbug.com/569332 for more details.
+ if (show && getAdapterInputConnection() == null) return false;
+ return show == mInputMethodManagerWrapper.isShowWithoutHideOutstanding();
}
});
}
« no previous file with comments | « content/public/android/java/src/org/chromium/content/browser/input/ImeAdapter.java ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698