Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Issue 1533613002: PPC: [turbofan] Change TruncateFloat32ToUint64 to TryTruncateFloat32ToUint64. (Closed)

Created:
5 years ago by MTBrandyberry
Modified:
5 years ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@patch08
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC: [turbofan] Change TruncateFloat32ToUint64 to TryTruncateFloat32ToUint64. Port 97161a29eda804ea17ba127e78ddaecee0a259a9 Original commit message: TryTruncateFloat32ToUint64 converts a float32 to a uint64. Additionally it provides an optional second return value which indicates whether the conversion succeeded (i.e. float32 value was within uint64 range) or not. Additionally I fixed a bug on x64 and mips64 in the implementation of TryTruncateFloat64ToUint64. Cases where the input value was between -1 and 0 were handled incorrectly. R=ahaas@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG= Committed: https://crrev.com/9418a710c16ae29c244175a771e1e4d8e74ee4b6 Cr-Commit-Position: refs/heads/master@{#32919}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -45 lines) Patch
M src/compiler/ppc/code-generator-ppc.cc View 1 chunk +10 lines, -1 line 0 comments Download
M src/compiler/ppc/instruction-selector-ppc.cc View 2 chunks +23 lines, -44 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 7 (2 generated)
MTBrandyberry
5 years ago (2015-12-16 19:30:06 UTC) #1
michael_dawson
On 2015/12/16 19:30:06, mtbrandyberry wrote: lgtm
5 years ago (2015-12-16 19:41:36 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1533613002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1533613002/1
5 years ago (2015-12-16 19:56:09 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-16 20:17:53 UTC) #5
commit-bot: I haz the power
5 years ago (2015-12-16 20:18:37 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9418a710c16ae29c244175a771e1e4d8e74ee4b6
Cr-Commit-Position: refs/heads/master@{#32919}

Powered by Google App Engine
This is Rietveld 408576698