Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(235)

Issue 1530273002: PPC: [turbofan] Change TruncateFloat32ToInt64 to TryTruncateFloat32ToInt64. (Closed)

Created:
5 years ago by MTBrandyberry
Modified:
5 years ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC: [turbofan] Change TruncateFloat32ToInt64 to TryTruncateFloat32ToInt64. Port 28261daa47d406d73e40bf4afba16ee61f300089 Original commit message: This operator now provides a second output which indicates whether the conversion from float32 to int64 was successful or not. The second output returns 0 if the conversion fails, or something else if the conversion succeeds. The second output can be ignored, which means that the operator can be used the same as the original operator. R=ahaas@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG= Committed: https://crrev.com/99b8e7c88dc4b6ce3f32d7a502c76c305abc6a11 Cr-Commit-Position: refs/heads/master@{#32914}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -2 lines) Patch
M src/compiler/ppc/instruction-selector-ppc.cc View 1 chunk +14 lines, -2 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 11 (4 generated)
MTBrandyberry
5 years ago (2015-12-16 19:27:01 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1530273002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1530273002/1
5 years ago (2015-12-16 19:27:13 UTC) #3
michael_dawson
On 2015/12/16 19:27:13, commit-bot: I haz the power wrote: > Dry run: CQ is trying ...
5 years ago (2015-12-16 19:28:50 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years ago (2015-12-16 19:49:19 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1530273002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1530273002/1
5 years ago (2015-12-16 19:54:25 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-16 19:55:50 UTC) #9
commit-bot: I haz the power
5 years ago (2015-12-16 19:56:13 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/99b8e7c88dc4b6ce3f32d7a502c76c305abc6a11
Cr-Commit-Position: refs/heads/master@{#32914}

Powered by Google App Engine
This is Rietveld 408576698