Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(275)

Unified Diff: src/compiler/ppc/instruction-selector-ppc.cc

Issue 1533613002: PPC: [turbofan] Change TruncateFloat32ToUint64 to TryTruncateFloat32ToUint64. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@patch08
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/compiler/ppc/code-generator-ppc.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/compiler/ppc/instruction-selector-ppc.cc
diff --git a/src/compiler/ppc/instruction-selector-ppc.cc b/src/compiler/ppc/instruction-selector-ppc.cc
index ed1b1b832f8165dd4b8e7ce6e15036fa9ce90d4f..9a57a777f67f5362f0c78f16e0dd48f218f13ebc 100644
--- a/src/compiler/ppc/instruction-selector-ppc.cc
+++ b/src/compiler/ppc/instruction-selector-ppc.cc
@@ -95,6 +95,25 @@ void VisitRRO(InstructionSelector* selector, ArchOpcode opcode, Node* node,
}
+#if V8_TARGET_ARCH_PPC64
+void VisitTryTruncateDouble(InstructionSelector* selector, ArchOpcode opcode,
+ Node* node) {
+ PPCOperandGenerator g(selector);
+ InstructionOperand inputs[] = {g.UseRegister(node->InputAt(0))};
+ InstructionOperand outputs[2];
+ size_t output_count = 0;
+ outputs[output_count++] = g.DefineAsRegister(node);
+
+ Node* success_output = NodeProperties::FindProjection(node, 1);
+ if (success_output) {
+ outputs[output_count++] = g.DefineAsRegister(success_output);
+ }
+
+ selector->Emit(opcode, output_count, outputs, 1, inputs);
+}
+#endif
+
+
// Shared routine for multiple binary operations.
template <typename Matcher>
void VisitBinop(InstructionSelector* selector, Node* node,
@@ -928,62 +947,22 @@ void InstructionSelector::VisitChangeFloat64ToUint32(Node* node) {
#if V8_TARGET_ARCH_PPC64
void InstructionSelector::VisitTryTruncateFloat32ToInt64(Node* node) {
- PPCOperandGenerator g(this);
-
- InstructionOperand inputs[] = {g.UseRegister(node->InputAt(0))};
- InstructionOperand outputs[2];
- size_t output_count = 0;
- outputs[output_count++] = g.DefineAsRegister(node);
-
- Node* success_output = NodeProperties::FindProjection(node, 1);
- if (success_output) {
- outputs[output_count++] = g.DefineAsRegister(success_output);
- }
-
- Emit(kPPC_DoubleToInt64, output_count, outputs, 1, inputs);
+ VisitTryTruncateDouble(this, kPPC_DoubleToInt64, node);
}
void InstructionSelector::VisitTryTruncateFloat64ToInt64(Node* node) {
- PPCOperandGenerator g(this);
-
- InstructionOperand inputs[] = {g.UseRegister(node->InputAt(0))};
- InstructionOperand outputs[2];
- size_t output_count = 0;
- outputs[output_count++] = g.DefineAsRegister(node);
-
- Node* success_output = NodeProperties::FindProjection(node, 1);
- if (success_output) {
- outputs[output_count++] = g.DefineAsRegister(success_output);
- }
-
- Emit(kPPC_DoubleToInt64, output_count, outputs, 1, inputs);
+ VisitTryTruncateDouble(this, kPPC_DoubleToInt64, node);
}
void InstructionSelector::VisitTryTruncateFloat32ToUint64(Node* node) {
- if (NodeProperties::FindProjection(node, 1)) {
- // TODO(ppc): implement the second return value.
- UNIMPLEMENTED();
- }
- VisitRR(this, kPPC_DoubleToUint64, node);
+ VisitTryTruncateDouble(this, kPPC_DoubleToUint64, node);
}
void InstructionSelector::VisitTryTruncateFloat64ToUint64(Node* node) {
- PPCOperandGenerator g(this);
-
- InstructionOperand inputs[] = {g.UseRegister(node->InputAt(0))};
- InstructionOperand outputs[2];
- size_t output_count = 0;
- outputs[output_count++] = g.DefineAsRegister(node);
-
- Node* success_output = NodeProperties::FindProjection(node, 1);
- if (success_output) {
- outputs[output_count++] = g.DefineAsRegister(success_output);
- }
-
- Emit(kPPC_DoubleToUint64, output_count, outputs, 1, inputs);
+ VisitTryTruncateDouble(this, kPPC_DoubleToUint64, node);
}
« no previous file with comments | « src/compiler/ppc/code-generator-ppc.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698