Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Issue 1533593004: Fix several wasm warnings an a use after free. (Closed)

Created:
5 years ago by bradn
Modified:
5 years ago
Reviewers:
ahaas
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix several wasm warnings an a use after free. Fixing several signed/unsigned comparison warnings for wasm. Fixing a use after free involving ostringsteam::str() R=ahaas@chromium.org BUG= Committed: https://crrev.com/78030950fa1d6f1058b92b300945adf3935143f2 Cr-Commit-Position: refs/heads/master@{#32946}

Patch Set 1 #

Total comments: 2

Patch Set 2 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -20 lines) Patch
M src/wasm/ast-decoder.h View 1 chunk +4 lines, -2 lines 0 comments Download
M src/wasm/ast-decoder.cc View 1 9 chunks +14 lines, -8 lines 0 comments Download
M src/wasm/decoder.h View 1 chunk +1 line, -1 line 0 comments Download
M src/wasm/encoder.h View 1 chunk +1 line, -1 line 0 comments Download
M src/wasm/encoder.cc View 6 chunks +6 lines, -6 lines 0 comments Download
M src/wasm/module-decoder.cc View 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
bradn
5 years ago (2015-12-17 11:01:09 UTC) #1
ahaas
lgtm lgtm (some nits) https://codereview.chromium.org/1533593004/diff/1/src/wasm/ast-decoder.cc File src/wasm/ast-decoder.cc (right): https://codereview.chromium.org/1533593004/diff/1/src/wasm/ast-decoder.cc#newcode1001 src/wasm/ast-decoder.cc:1001: for (int i = 1; ...
5 years ago (2015-12-17 11:51:12 UTC) #2
bradn
https://codereview.chromium.org/1533593004/diff/1/src/wasm/ast-decoder.cc File src/wasm/ast-decoder.cc (right): https://codereview.chromium.org/1533593004/diff/1/src/wasm/ast-decoder.cc#newcode1001 src/wasm/ast-decoder.cc:1001: for (int i = 1; i < static_cast<int>(count); i++) ...
5 years ago (2015-12-17 12:09:52 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1533593004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1533593004/20001
5 years ago (2015-12-17 12:10:05 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years ago (2015-12-17 12:34:23 UTC) #7
commit-bot: I haz the power
5 years ago (2015-12-17 12:35:12 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/78030950fa1d6f1058b92b300945adf3935143f2
Cr-Commit-Position: refs/heads/master@{#32946}

Powered by Google App Engine
This is Rietveld 408576698