Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(316)

Side by Side Diff: src/wasm/encoder.h

Issue 1533593004: Fix several wasm warnings an a use after free. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: fix Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/wasm/decoder.h ('k') | src/wasm/encoder.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 the V8 project authors. All rights reserved. 1 // Copyright 2015 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef V8_WASM_ENCODER_H_ 5 #ifndef V8_WASM_ENCODER_H_
6 #define V8_WASM_ENCODER_H_ 6 #define V8_WASM_ENCODER_H_
7 7
8 #include "src/signature.h" 8 #include "src/signature.h"
9 #include "src/zone-containers.h" 9 #include "src/zone-containers.h"
10 10
(...skipping 117 matching lines...) Expand 10 before | Expand all | Expand 10 after
128 uint16_t AddFunction(const unsigned char* name = NULL, int name_length = 0); 128 uint16_t AddFunction(const unsigned char* name = NULL, int name_length = 0);
129 uint32_t AddGlobal(MachineType type, bool exported); 129 uint32_t AddGlobal(MachineType type, bool exported);
130 WasmFunctionBuilder* FunctionAt(size_t index); 130 WasmFunctionBuilder* FunctionAt(size_t index);
131 void AddDataSegment(WasmDataSegmentEncoder* data); 131 void AddDataSegment(WasmDataSegmentEncoder* data);
132 uint16_t AddSignature(FunctionSig* sig); 132 uint16_t AddSignature(FunctionSig* sig);
133 void AddIndirectFunction(uint16_t index); 133 void AddIndirectFunction(uint16_t index);
134 WasmModuleWriter* Build(Zone* zone); 134 WasmModuleWriter* Build(Zone* zone);
135 135
136 private: 136 private:
137 struct CompareFunctionSigs { 137 struct CompareFunctionSigs {
138 int operator()(FunctionSig* a, FunctionSig* b); 138 int operator()(FunctionSig* a, FunctionSig* b) const;
139 }; 139 };
140 typedef ZoneMap<FunctionSig*, uint16_t, CompareFunctionSigs> SignatureMap; 140 typedef ZoneMap<FunctionSig*, uint16_t, CompareFunctionSigs> SignatureMap;
141 141
142 Zone* zone_; 142 Zone* zone_;
143 ZoneVector<FunctionSig*> signatures_; 143 ZoneVector<FunctionSig*> signatures_;
144 ZoneVector<WasmFunctionBuilder*> functions_; 144 ZoneVector<WasmFunctionBuilder*> functions_;
145 ZoneVector<WasmDataSegmentEncoder*> data_segments_; 145 ZoneVector<WasmDataSegmentEncoder*> data_segments_;
146 ZoneVector<uint16_t> indirect_functions_; 146 ZoneVector<uint16_t> indirect_functions_;
147 ZoneVector<std::pair<MachineType, bool>> globals_; 147 ZoneVector<std::pair<MachineType, bool>> globals_;
148 SignatureMap signature_map_; 148 SignatureMap signature_map_;
149 }; 149 };
150 150
151 std::vector<uint8_t> UnsignedLEB128From(uint32_t result); 151 std::vector<uint8_t> UnsignedLEB128From(uint32_t result);
152 } // namespace wasm 152 } // namespace wasm
153 } // namespace internal 153 } // namespace internal
154 } // namespace v8 154 } // namespace v8
155 155
156 #endif // V8_WASM_ENCODER_H_ 156 #endif // V8_WASM_ENCODER_H_
OLDNEW
« no previous file with comments | « src/wasm/decoder.h ('k') | src/wasm/encoder.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698