content/browser/download/download_manager_impl_unittest.cc - Issue 1533583002: [Downloads] Factor out request handling logic between DRH and UD.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/download/download_manager_impl_unittest.cc

Issue 1533583002: [Downloads] Factor out request handling logic between DRH and UD. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Why aren't there tests for sniffed MIME types? Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/download/download_create_info.cc ('K') | « content/browser/download/download_manager_impl.cc ('k') | content/browser/download/download_request_core.h » ('j') | content/browser/download/url_downloader.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/download/download_manager_impl_unittest.cc

diff --git a/content/browser/download/download_manager_impl_unittest.cc b/content/browser/download/download_manager_impl_unittest.cc

index 36c074b7cd3d78849a9ec217cacc0c4d3586a112..163858eca5c482cea1d0e5117c7df672f09253af 100644

--- a/content/browser/download/download_manager_impl_unittest.cc

+++ b/content/browser/download/download_manager_impl_unittest.cc

@@ -519,7 +519,7 @@ class DownloadManagerTest : public testing::Test {

// null.

uint32 id = next_download_id_;

++next_download_id_;

- info.request_handle = DownloadRequestHandle();

+ info.request_handle.reset(new DownloadRequestHandle());

svaldez 2015/12/17 16:53:32 nit: (new DownloadRequestHandle);

asanka 2015/12/21 20:14:02 Done.

download_manager_->CreateActiveItem(id, info);

DCHECK(mock_download_item_factory_->GetItem(id));

MockDownloadItemImpl& item(*mock_download_item_factory_->GetItem(id));