[Downloads] Factor out request handling logic between DRH and UD.

content/browser/download/download_create_info.cc

Index: content/browser/download/download_create_info.cc
diff --git a/content/browser/download/download_create_info.cc b/content/browser/download/download_create_info.cc
index 05b0992a26dc31035362b263ae6ada37ef5fbcf2..fecbb2a79e1cbba7de6990ba1c5f6b3fd9ea9d0c 100644
--- a/content/browser/download/download_create_info.cc
+++ b/content/browser/download/download_create_info.cc
@@ -14,39 +14,32 @@ namespace content {
 DownloadCreateInfo::DownloadCreateInfo(const base::Time& start_time,
                                        int64 total_bytes,
                                        const net::BoundNetLog& bound_net_log,
-                                       bool has_user_gesture,
-                                       ui::PageTransition transition_type,
                                        scoped_ptr<DownloadSaveInfo> save_info)
     : start_time(start_time),
       total_bytes(total_bytes),
       download_id(DownloadItem::kInvalidId),
-      has_user_gesture(has_user_gesture),
-      transition_type(transition_type),
+      has_user_gesture(false),
+      transition_type(ui::PAGE_TRANSITION_LINK),
       save_info(save_info.Pass()),
       request_bound_net_log(bound_net_log) {}
 
 DownloadCreateInfo::DownloadCreateInfo()
-    : total_bytes(0),
-      download_id(DownloadItem::kInvalidId),
-      has_user_gesture(false),
-      transition_type(ui::PAGE_TRANSITION_LINK),
-      save_info(new DownloadSaveInfo()) {
-}
+    : DownloadCreateInfo(base::Time(),
+                         0,
+                         net::BoundNetLog(),
+                         make_scoped_ptr(new DownloadSaveInfo())) {}

[svaldez, 2015/12/17 16:53:32]

(new DownloadSaveInfo)

[asanka, 2015/12/21 20:14:02]

Done.

 
-DownloadCreateInfo::~DownloadCreateInfo() {
-}
+DownloadCreateInfo::~DownloadCreateInfo() {}
 
 std::string DownloadCreateInfo::DebugString() const {
-  return base::StringPrintf("{"
-                            " download_id = %u"
-                            " url = \"%s\""
-                            " request_handle = %s"
-                            " total_bytes = %" PRId64
-                            " }",
-                            download_id,
-                            url().spec().c_str(),
-                            request_handle.DebugString().c_str(),
-                            total_bytes);
+  return base::StringPrintf(
+      "{"
+      " download_id = %u"
+      " url = \"%s\""
+      " request_handle = %s"
+      " total_bytes = %" PRId64 " }",
+      download_id, url().spec().c_str(), request_handle->DebugString().c_str(),
+      total_bytes);

[svaldez, 2015/12/17 16:53:32]

nit: Possibly revert to separate lines since that's slightly clearer.

[asanka, 2015/12/21 20:14:02]

Unfortunately, this is clang format's handywork.

 }
 
 const GURL& DownloadCreateInfo::url() const {