[Downloads] Factor out request handling logic between DRH and UD.

content/browser/download/download_manager_impl_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <set>
 #include <string>
 
 #include "base/bind.h"
 #include "base/files/scoped_temp_dir.h"
 #include "base/memory/scoped_ptr.h"
@@ skipping 501 matching lines @@
   }
 
   // Returns download id.
   MockDownloadItemImpl& AddItemToManager() {
     DownloadCreateInfo info;
 
     // Args are ignored except for download id, so everything else can be
     // null.
     uint32 id = next_download_id_;
     ++next_download_id_;
-    info.request_handle = DownloadRequestHandle();
+    info.request_handle.reset(new DownloadRequestHandle());

[svaldez, 2015/12/17 16:53:32]

nit: (new DownloadRequestHandle);

[asanka, 2015/12/21 20:14:02]

Done.

     download_manager_->CreateActiveItem(id, info);
     DCHECK(mock_download_item_factory_->GetItem(id));
     MockDownloadItemImpl& item(*mock_download_item_factory_->GetItem(id));
     // Satisfy expectation.  If the item is created in StartDownload(),
     // we call Start on it immediately, so we need to set that expectation
     // in the factory.
     scoped_ptr<DownloadRequestHandleInterface> req_handle;
     item.Start(scoped_ptr<DownloadFile>(), req_handle.Pass());
     DCHECK(id < download_urls_.size());
     EXPECT_CALL(item, GetURL()).WillRepeatedly(ReturnRef(download_urls_[id]));
@@ skipping 185 matching lines @@
   EXPECT_CALL(GetMockDownloadItem(0), Remove());
   EXPECT_CALL(GetMockDownloadItem(1), Remove()).Times(0);
 
   url::Origin origin_to_clear(download_urls_[0]);
   int remove_count = download_manager_->RemoveDownloadsByOriginAndTime(
       origin_to_clear, base::Time(), base::Time::Max());
   EXPECT_EQ(remove_count, 1);
 }
 
 }  // namespace content