DescriptionRevert of Make base a static ibrary (patchset #3 id:40001 of https://codereview.chromium.org/1528233002/ )
Reason for revert:
Breaks Win GN link:
unresolved external symbol JSONFileValueDeserializer::JSONFileValueDeserializer ... referenced in function "class JsonPrefStore::ReadResult> > __cdecl `anonymous namespace'::ReadPrefsFromDisk ...
https://build.chromium.org/p/chromium.win/builders/Win%20x64%20GN%20%28dbg%29/builds/15424/steps/compile/logs/stdio
Original issue's description:
> Make base a static ibrary
>
> This saves a nontrivial amount of space for some of the smaller targets in release builds. See the comment added to the base target for more.
>
> Remove libmojo_sdk. This is a complete static library that depended on base. Since base is now a static library, this dependency is not allowed. The mojo team says this target is no longer needed, so it was deleted.
>
> Committed: https://crrev.com/89c7be623e3cc5052aaf8c3be3996432a9d4bceb
> Cr-Commit-Position: refs/heads/master@{#365955}
TBR=dpranke@chromium.org,brettw@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Committed: https://crrev.com/666f25fff59502a70563a63e9b848d03fc547fde
Cr-Commit-Position: refs/heads/master@{#366062}
Patch Set 1 #
Messages
Total messages: 7 (2 generated)
|