Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Issue 1532953003: Revert of Make base a static ibrary (Closed)

Created:
5 years ago by phoglund_chromium
Modified:
5 years ago
Reviewers:
Dirk Pranke, brettw
CC:
chromium-reviews, qsr+mojo_chromium.org, vmpstr+watch_chromium.org, wfh+watch_chromium.org, viettrungluu+watch_chromium.org, gavinp+memory_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, rickyz+watch_chromium.org, asvitkine+watch_chromium.org, tracing+reviews_chromium.org, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Make base a static ibrary (patchset #3 id:40001 of https://codereview.chromium.org/1528233002/ ) Reason for revert: Breaks Win GN link: unresolved external symbol JSONFileValueDeserializer::JSONFileValueDeserializer ... referenced in function "class JsonPrefStore::ReadResult> > __cdecl `anonymous namespace'::ReadPrefsFromDisk ... https://build.chromium.org/p/chromium.win/builders/Win%20x64%20GN%20%28dbg%29/builds/15424/steps/compile/logs/stdio Original issue's description: > Make base a static ibrary > > This saves a nontrivial amount of space for some of the smaller targets in release builds. See the comment added to the base target for more. > > Remove libmojo_sdk. This is a complete static library that depended on base. Since base is now a static library, this dependency is not allowed. The mojo team says this target is no longer needed, so it was deleted. > > Committed: https://crrev.com/89c7be623e3cc5052aaf8c3be3996432a9d4bceb > Cr-Commit-Position: refs/heads/master@{#365955} TBR=dpranke@chromium.org,brettw@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/666f25fff59502a70563a63e9b848d03fc547fde Cr-Commit-Position: refs/heads/master@{#366062}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -80 lines) Patch
M base/BUILD.gn View 2 chunks +33 lines, -49 lines 0 comments Download
M base/debug/BUILD.gn View 1 chunk +1 line, -2 lines 0 comments Download
M base/json/BUILD.gn View 1 chunk +1 line, -2 lines 0 comments Download
M base/memory/BUILD.gn View 1 chunk +1 line, -2 lines 0 comments Download
M base/metrics/BUILD.gn View 1 chunk +1 line, -14 lines 0 comments Download
M base/process/BUILD.gn View 1 chunk +1 line, -2 lines 0 comments Download
M base/third_party/dynamic_annotations/BUILD.gn View 1 chunk +1 line, -2 lines 0 comments Download
M base/trace_event/BUILD.gn View 1 chunk +1 line, -2 lines 0 comments Download
M mojo/public/BUILD.gn View 2 chunks +8 lines, -0 lines 0 comments Download
M sandbox/win/BUILD.gn View 1 chunk +1 line, -5 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
phoglund_chromium
Created Revert of Make base a static ibrary
5 years ago (2015-12-18 09:22:44 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1532953003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1532953003/1
5 years ago (2015-12-18 09:23:08 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-18 09:24:31 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/666f25fff59502a70563a63e9b848d03fc547fde Cr-Commit-Position: refs/heads/master@{#366062}
5 years ago (2015-12-18 09:25:30 UTC) #6
Dirk Pranke
5 years ago (2015-12-18 16:27:16 UTC) #7
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698