Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(304)

Unified Diff: base/json/BUILD.gn

Issue 1532953003: Revert of Make base a static ibrary (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/debug/BUILD.gn ('k') | base/memory/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/json/BUILD.gn
diff --git a/base/json/BUILD.gn b/base/json/BUILD.gn
index 206b5b0025869b3d9e8d811d20386b71b8cb9999..5cb42a3249ad569ed6895a84340b21482a354d07 100644
--- a/base/json/BUILD.gn
+++ b/base/json/BUILD.gn
@@ -4,8 +4,7 @@
import("//build/config/nacl/config.gni")
-# Should be static library, see documentation on //base:base for discussion.
-static_library("json") {
+source_set("json") {
sources = [
"json_file_value_serializer.cc",
"json_file_value_serializer.h",
« no previous file with comments | « base/debug/BUILD.gn ('k') | base/memory/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698