Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Side by Side Diff: base/metrics/BUILD.gn

Issue 1532953003: Revert of Make base a static ibrary (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « base/memory/BUILD.gn ('k') | base/process/BUILD.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2015 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2015 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 # TODO(phosek) bug 570839: If field_trial.cc is in a static library, 5 source_set("metrics") {
6 # hacl_helper_nonsfi doesn't link properly on Linux in debug builds. The
7 # reasons for this seem to involve obscure toolchain bugs. This should be fixed
8 # and this target should be a static_library unconditionally.
9 import("//build/config/nacl/config.gni")
10 if (is_nacl_nonsfi) {
11 metrics_target_type = "source_set"
12 } else {
13 metrics_target_type = "static_library"
14 }
15
16 # Should be static library, see documentation on //base:base for discussion.
17 #static_library("metrics") { # Should be this when above TODO is resolved.
18 target(metrics_target_type, "metrics") {
19 sources = [ 6 sources = [
20 "bucket_ranges.cc", 7 "bucket_ranges.cc",
21 "bucket_ranges.h", 8 "bucket_ranges.h",
22 "field_trial.cc", 9 "field_trial.cc",
23 "field_trial.h", 10 "field_trial.h",
24 "histogram.cc", 11 "histogram.cc",
25 "histogram.h", 12 "histogram.h",
26 "histogram_base.cc", 13 "histogram_base.cc",
27 "histogram_base.h", 14 "histogram_base.h",
28 "histogram_delta_serialization.cc", 15 "histogram_delta_serialization.cc",
(...skipping 28 matching lines...) Expand all
57 "//base/process", 44 "//base/process",
58 ] 45 ]
59 46
60 allow_circular_includes_from = [ 47 allow_circular_includes_from = [
61 "//base/memory", 48 "//base/memory",
62 "//base/process", 49 "//base/process",
63 ] 50 ]
64 51
65 visibility = [ "//base/*" ] 52 visibility = [ "//base/*" ]
66 } 53 }
OLDNEW
« no previous file with comments | « base/memory/BUILD.gn ('k') | base/process/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698