Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(362)

Issue 1532883004: Merged: Trigger MSE players UMA by user events only (Closed)

Created:
5 years ago by Tima Vaisburd
Modified:
5 years ago
Reviewers:
timav
CC:
chromium-reviews, posciak+watch_chromium.org, feature-media-reviews_chromium.org, avayvod+watch_chromium.org, mcasas+watch_chromium.org, mlamouri+watch-media_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@2564
Target Ref:
refs/pending/branch-heads/2564
Project:
chromium
Visibility:
Public.

Description

Merged: Trigger MSE players UMA by user events only This is the second fix for MediaSourcePlayer and MediaCodecPlayer UMA statistics gathering (first was https://codereview.chromium.org/1458783002). This CL calls the MediaStatistics::StopAndReport call from the MediaCodecPlayer's top-level methods Pause(), SeekTo(), Release(), when the error detected and when the end of stream is detected, instead of calling it internally when the state machine went to the stopped state. By doing this we shall make MediaCodecPlayer behavior to be the same as the MediaSourcePlayer and do not record an artificial playback stop on internal event like starvation or resultion change with the decoder drain. This CL already eliminates an incorrect stop detection when the user switches to the fullscreen mode and back while playing. BUG=407577, 570835 TBR=timav > Review URL: https://codereview.chromium.org/1537583002 > Cr-Commit-Position: refs/heads/master@{#365967} Committed: https://chromium.googlesource.com/chromium/src/+/af7e7ed5278fbbef4da9130ca81bcc8e1a184579

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -16 lines) Patch
M media/base/android/media_codec_player.cc View 12 chunks +17 lines, -10 lines 0 comments Download
M media/base/android/media_source_player.cc View 3 chunks +3 lines, -4 lines 0 comments Download
M media/base/android/media_statistics.h View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Tima Vaisburd
5 years ago (2015-12-18 02:21:54 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
af7e7ed5278fbbef4da9130ca81bcc8e1a184579.

Powered by Google App Engine
This is Rietveld 408576698