Fix UMA metrics for MediaSourcePlayer.

Fix UMA metrics for MediaSourcePlayer.

This should be part of CL https://codereview.chromium.org/1367403003.

BUG=407577, 557513
Committed: https://crrev.com/b7c7f99ace5d1d508ae692b20950dd8759e8787d
Cr-Commit-Position: refs/heads/master@{#360428}

[Tima Vaisburd, 2015-11-18 02:49:12]

timav@chromium.org changed reviewers:
+ qinmin@chromium.org

[Tima Vaisburd, 2015-11-18 02:49:12]

PTAL

[qinmin, 2015-11-18 18:12:28]

https://codereview.chromium.org/1458783002/diff/1/media/base/android/media_so...
File media/base/android/media_source_player.cc (right):

https://codereview.chromium.org/1458783002/diff/1/media/base/android/media_so...
media/base/android/media_source_player.cc:93: // Need to stop here to prevent
false reports while seek and drag.
Do we need this? We should have captured this situation in
MediaDecoderCallback().

[Tima Vaisburd, 2015-11-18 18:31:13]

https://codereview.chromium.org/1458783002/diff/1/media/base/android/media_so...
File media/base/android/media_source_player.cc (right):

https://codereview.chromium.org/1458783002/diff/1/media/base/android/media_so...
media/base/android/media_source_player.cc:93: // Need to stop here to prevent
false reports while seek and drag.
On 2015/11/18 18:12:27, qinmin wrote:
> Do we need this? We should have captured this situation in
> MediaDecoderCallback().

I think we do. During the seek-and-drag II did not see the MediaDecoderCallback
coming. We have many Starts in rapid sequence without StopAndReport, which leads
to another wrong long duration. And we need the first Start to take effect
instead of the last one because of starvations that can be "invisible" (come and
go, playback continues).

[qinmin, 2015-11-18 19:11:43]

https://codereview.chromium.org/1458783002/diff/1/media/base/android/media_so...
File media/base/android/media_source_player.cc (right):

https://codereview.chromium.org/1458783002/diff/1/media/base/android/media_so...
media/base/android/media_source_player.cc:93: // Need to stop here to prevent
false reports while seek and drag.
On 2015/11/18 18:31:13, Tima Vaisburd wrote:
> On 2015/11/18 18:12:27, qinmin wrote:
> > Do we need this? We should have captured this situation in
> > MediaDecoderCallback().
> 
> I think we do. During the seek-and-drag II did not see the
MediaDecoderCallback
> coming. We have many Starts in rapid sequence without StopAndReport, which
leads
> to another wrong long duration. And we need the first Start to take effect
> instead of the last one because of starvations that can be "invisible" (come
and
> go, playback continues).

Start() will automatically kick off the MediaDecoderJob to start requesting or
decoding data, wouldn't that leads to MediaDecoderCallback() later?

[Tima Vaisburd, 2015-11-18 20:02:12]

https://codereview.chromium.org/1458783002/diff/1/media/base/android/media_so...
File media/base/android/media_source_player.cc (right):

https://codereview.chromium.org/1458783002/diff/1/media/base/android/media_so...
media/base/android/media_source_player.cc:93: // Need to stop here to prevent
false reports while seek and drag.
On 2015/11/18 19:11:43, qinmin wrote:
> On 2015/11/18 18:31:13, Tima Vaisburd wrote:
> > On 2015/11/18 18:12:27, qinmin wrote:
> > > Do we need this? We should have captured this situation in
> > > MediaDecoderCallback().
> > 
> > I think we do. During the seek-and-drag II did not see the
> MediaDecoderCallback
> > coming. We have many Starts in rapid sequence without StopAndReport, which
> leads
> > to another wrong long duration. And we need the first Start to take effect
> > instead of the last one because of starvations that can be "invisible" (come
> and
> > go, playback continues).
> 
> Start() will automatically kick off the MediaDecoderJob to start requesting or
> decoding data, wouldn't that leads to MediaDecoderCallback() later?

Yes, you are right, sorry I misled you. The bug was in the MediaStatistics where
I did wrong treatment of the unknown current time.

[qinmin, 2015-11-18 20:46:30]

lgtm

[Tima Vaisburd, 2015-11-18 20:52:59]

The CQ bit was checked by timav@chromium.org

[commit-bot: I haz the power, 2015-11-18 20:53:16]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1458783002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1458783002/20001

[commit-bot: I haz the power, 2015-11-18 22:13:15]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-11-18 22:14:37]

Patchset 2 (id:??) landed as
https://crrev.com/b7c7f99ace5d1d508ae692b20950dd8759e8787d
Cr-Commit-Position: refs/heads/master@{#360428}