Trigger MSE players UMA by user events only

Trigger MSE players UMA by user events only

This is the second fix for MediaSourcePlayer and MediaCodecPlayer UMA
statistics gathering (first was https://codereview.chromium.org/1458783002).

This CL calls the MediaStatistics::StopAndReport call from
the MediaCodecPlayer's top-level methods Pause(), SeekTo(), Release(),
when the error detected and when the end of stream is detected,
instead of calling it internally when the state machine went to
the stopped state.

By doing this we shall make MediaCodecPlayer behavior to be the
same as the MediaSourcePlayer and do not record an artificial
playback stop on internal event like starvation or resultion
change with the decoder drain.

This CL already eliminates an incorrect stop detection when the
user switches to the fullscreen mode and back while playing.

BUG=407577, 570835
Committed: https://crrev.com/12260055d88cfc677a2a50135792d364777641f5
Cr-Commit-Position: refs/heads/master@{#365967}

[Tima Vaisburd, 2015-12-17 03:34:15]

timav@chromium.org changed reviewers:
+ qinmin@chromium.org

[Tima Vaisburd, 2015-12-17 03:34:16]

PTAL

[qinmin, 2015-12-17 07:16:35]

lgtm, please verify that this works fine with surface changes as we no longer
record the duration on browser seek

[Tima Vaisburd, 2015-12-17 23:05:53]

Description was changed from

==========
Trigger MSE players UMA by user events only

This is the second fix for MediaSourcePlayer and MediaCodecPlayer
UMA statistics gathering.

This CL calls the MediaStatistics::StopAndReport call from
the MediaCodecPlayer's top-level methods Pause(), SeekTo(), Release(),
when the error detected and when the end of stream is detected,
instead of calling it internally when the state machine went to
the stopped state.

By doing this we shall make MediaCodecPlayer behavior to be the
same as the MediaSourcePlayer and do not record an artificial
playback stop on internal event like starvation or resultion
change with the decoder drain.

This CL already eliminates an incorrect stop detection when the
user switches to the fullscreen mode and back while playing.

BUG=407577

Extra log for debuging with tvlog - DO NOT LAND
==========

to

==========
Trigger MSE players UMA by user events only

This is the second fix for MediaSourcePlayer and MediaCodecPlayer
UMA statistics gathering.

This CL calls the MediaStatistics::StopAndReport call from
the MediaCodecPlayer's top-level methods Pause(), SeekTo(), Release(),
when the error detected and when the end of stream is detected,
instead of calling it internally when the state machine went to
the stopped state.

By doing this we shall make MediaCodecPlayer behavior to be the
same as the MediaSourcePlayer and do not record an artificial
playback stop on internal event like starvation or resultion
change with the decoder drain.

This CL already eliminates an incorrect stop detection when the
user switches to the fullscreen mode and back while playing.

BUG=407577, 570835
==========

[Tima Vaisburd, 2015-12-17 23:08:02]

Description was changed from

==========
Trigger MSE players UMA by user events only

This is the second fix for MediaSourcePlayer and MediaCodecPlayer
UMA statistics gathering.

This CL calls the MediaStatistics::StopAndReport call from
the MediaCodecPlayer's top-level methods Pause(), SeekTo(), Release(),
when the error detected and when the end of stream is detected,
instead of calling it internally when the state machine went to
the stopped state.

By doing this we shall make MediaCodecPlayer behavior to be the
same as the MediaSourcePlayer and do not record an artificial
playback stop on internal event like starvation or resultion
change with the decoder drain.

This CL already eliminates an incorrect stop detection when the
user switches to the fullscreen mode and back while playing.

BUG=407577, 570835
==========

to

==========
Trigger MSE players UMA by user events only

This is the second fix for MediaSourcePlayer and MediaCodecPlayer
UMA statistics gathering (first was https://codereview.chromium.org/1458783002).

This CL calls the MediaStatistics::StopAndReport call from
the MediaCodecPlayer's top-level methods Pause(), SeekTo(), Release(),
when the error detected and when the end of stream is detected,
instead of calling it internally when the state machine went to
the stopped state.

By doing this we shall make MediaCodecPlayer behavior to be the
same as the MediaSourcePlayer and do not record an artificial
playback stop on internal event like starvation or resultion
change with the decoder drain.

This CL already eliminates an incorrect stop detection when the
user switches to the fullscreen mode and back while playing.

BUG=407577, 570835
==========

[Tima Vaisburd, 2015-12-17 23:08:25]

Description was changed from

==========
Trigger MSE players UMA by user events only

This is the second fix for MediaSourcePlayer and MediaCodecPlayer
UMA statistics gathering (first was https://codereview.chromium.org/1458783002).

This CL calls the MediaStatistics::StopAndReport call from
the MediaCodecPlayer's top-level methods Pause(), SeekTo(), Release(),
when the error detected and when the end of stream is detected,
instead of calling it internally when the state machine went to
the stopped state.

By doing this we shall make MediaCodecPlayer behavior to be the
same as the MediaSourcePlayer and do not record an artificial
playback stop on internal event like starvation or resultion
change with the decoder drain.

This CL already eliminates an incorrect stop detection when the
user switches to the fullscreen mode and back while playing.

BUG=407577, 570835
==========

to

==========
Trigger MSE players UMA by user events only

This is the second fix for MediaSourcePlayer and MediaCodecPlayer UMA
statistics gathering (first was https://codereview.chromium.org/1458783002).

This CL calls the MediaStatistics::StopAndReport call from
the MediaCodecPlayer's top-level methods Pause(), SeekTo(), Release(),
when the error detected and when the end of stream is detected,
instead of calling it internally when the state machine went to
the stopped state.

By doing this we shall make MediaCodecPlayer behavior to be the
same as the MediaSourcePlayer and do not record an artificial
playback stop on internal event like starvation or resultion
change with the decoder drain.

This CL already eliminates an incorrect stop detection when the
user switches to the fullscreen mode and back while playing.

BUG=407577, 570835
==========

[Tima Vaisburd, 2015-12-18 00:03:09]

On 2015/12/17 07:16:35, qinmin wrote:
> lgtm, please verify that this works fine with surface changes as we no longer
> record the duration on browser seek

Thank you for the prompt review!
I tested pretty hard, but I did test the previous version as well...

[Tima Vaisburd, 2015-12-18 00:03:24]

The CQ bit was checked by timav@chromium.org

[Tima Vaisburd, 2015-12-18 00:03:24]

The patchset sent to the CQ was uploaded after l-g-t-m from qinmin@chromium.org
Link to the patchset: https://codereview.chromium.org/1537583002/#ps20001
(title: "Rebase only")

[commit-bot: I haz the power, 2015-12-18 00:08:18]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1537583002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1537583002/20001

[commit-bot: I haz the power, 2015-12-18 01:29:38]

Description was changed from

==========
Trigger MSE players UMA by user events only

This is the second fix for MediaSourcePlayer and MediaCodecPlayer UMA
statistics gathering (first was https://codereview.chromium.org/1458783002).

This CL calls the MediaStatistics::StopAndReport call from
the MediaCodecPlayer's top-level methods Pause(), SeekTo(), Release(),
when the error detected and when the end of stream is detected,
instead of calling it internally when the state machine went to
the stopped state.

By doing this we shall make MediaCodecPlayer behavior to be the
same as the MediaSourcePlayer and do not record an artificial
playback stop on internal event like starvation or resultion
change with the decoder drain.

This CL already eliminates an incorrect stop detection when the
user switches to the fullscreen mode and back while playing.

BUG=407577, 570835
==========

to

==========
Trigger MSE players UMA by user events only

This is the second fix for MediaSourcePlayer and MediaCodecPlayer UMA
statistics gathering (first was https://codereview.chromium.org/1458783002).

This CL calls the MediaStatistics::StopAndReport call from
the MediaCodecPlayer's top-level methods Pause(), SeekTo(), Release(),
when the error detected and when the end of stream is detected,
instead of calling it internally when the state machine went to
the stopped state.

By doing this we shall make MediaCodecPlayer behavior to be the
same as the MediaSourcePlayer and do not record an artificial
playback stop on internal event like starvation or resultion
change with the decoder drain.

This CL already eliminates an incorrect stop detection when the
user switches to the fullscreen mode and back while playing.

BUG=407577, 570835
==========

[commit-bot: I haz the power, 2015-12-18 01:29:39]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-12-18 01:31:05]

Description was changed from

==========
Trigger MSE players UMA by user events only

This is the second fix for MediaSourcePlayer and MediaCodecPlayer UMA
statistics gathering (first was https://codereview.chromium.org/1458783002).

This CL calls the MediaStatistics::StopAndReport call from
the MediaCodecPlayer's top-level methods Pause(), SeekTo(), Release(),
when the error detected and when the end of stream is detected,
instead of calling it internally when the state machine went to
the stopped state.

By doing this we shall make MediaCodecPlayer behavior to be the
same as the MediaSourcePlayer and do not record an artificial
playback stop on internal event like starvation or resultion
change with the decoder drain.

This CL already eliminates an incorrect stop detection when the
user switches to the fullscreen mode and back while playing.

BUG=407577, 570835
==========

to

==========
Trigger MSE players UMA by user events only

This is the second fix for MediaSourcePlayer and MediaCodecPlayer UMA
statistics gathering (first was https://codereview.chromium.org/1458783002).

This CL calls the MediaStatistics::StopAndReport call from
the MediaCodecPlayer's top-level methods Pause(), SeekTo(), Release(),
when the error detected and when the end of stream is detected,
instead of calling it internally when the state machine went to
the stopped state.

By doing this we shall make MediaCodecPlayer behavior to be the
same as the MediaSourcePlayer and do not record an artificial
playback stop on internal event like starvation or resultion
change with the decoder drain.

This CL already eliminates an incorrect stop detection when the
user switches to the fullscreen mode and back while playing.

BUG=407577, 570835

Committed: https://crrev.com/12260055d88cfc677a2a50135792d364777641f5
Cr-Commit-Position: refs/heads/master@{#365967}
==========

[commit-bot: I haz the power, 2015-12-18 01:31:06]

Patchset 2 (id:??) landed as
https://crrev.com/12260055d88cfc677a2a50135792d364777641f5
Cr-Commit-Position: refs/heads/master@{#365967}