Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10490)

Unified Diff: chrome/browser/extensions/webstore_installer_unittest.cc

Issue 153273002: Include the language (locale) info in the update ping (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Comments, Unittest Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/extensions/webstore_installer.cc ('k') | chrome/browser/omaha_query_params/OWNERS » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/webstore_installer_unittest.cc
diff --git a/chrome/browser/extensions/webstore_installer_unittest.cc b/chrome/browser/extensions/webstore_installer_unittest.cc
index 734013afcdfa12f623c470ee2ea6bc96f8fc80ff..c1170035afc09e9115eafbf082887965a1fc6dd9 100644
--- a/chrome/browser/extensions/webstore_installer_unittest.cc
+++ b/chrome/browser/extensions/webstore_installer_unittest.cc
@@ -6,7 +6,7 @@
#include "base/strings/stringprintf.h"
#include "chrome/browser/extensions/webstore_installer.h"
-#include "chrome/common/omaha_query_params/omaha_query_params.h"
+#include "chrome/browser/omaha_query_params/omaha_query_params.h"
#include "extensions/common/id_util.h"
#include "net/base/escape.h"
#include "testing/gtest/include/gtest/gtest.h"
@@ -27,14 +27,18 @@ TEST(WebstoreInstallerTest, PlatformParams) {
GURL url = WebstoreInstaller::GetWebstoreInstallURL(id,
WebstoreInstaller::INSTALL_SOURCE_INLINE);
std::string query = url.query();
- EXPECT_TRUE(Contains(query,StringPrintf("os=%s", OmahaQueryParams::getOS())));
- EXPECT_TRUE(Contains(query,StringPrintf("arch=%s",
- OmahaQueryParams::getArch())));
- EXPECT_TRUE(Contains(query,StringPrintf("nacl_arch=%s",
- OmahaQueryParams::getNaclArch())));
- EXPECT_TRUE(Contains(query,net::EscapeQueryParamValue(
- StringPrintf("installsource=%s", source.c_str()),
- true)));
+ EXPECT_TRUE(
+ Contains(query, StringPrintf("os=%s", OmahaQueryParams::GetOS())));
+ EXPECT_TRUE(
+ Contains(query, StringPrintf("arch=%s", OmahaQueryParams::GetArch())));
+ EXPECT_TRUE(Contains(
+ query, StringPrintf("nacl_arch=%s", OmahaQueryParams::GetNaclArch())));
+ EXPECT_TRUE(
+ Contains(query,
+ net::EscapeQueryParamValue(
+ StringPrintf("installsource=%s", source.c_str()), true)));
+ EXPECT_TRUE(
+ Contains(query, StringPrintf("lang=%s", OmahaQueryParams::GetLang())));
}
} // namespace extensions
« no previous file with comments | « chrome/browser/extensions/webstore_installer.cc ('k') | chrome/browser/omaha_query_params/OWNERS » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698