chrome/browser/extensions/webstore_installer.cc - Issue 153273002: Include the language (locale) info in the update ping

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/webstore_installer.cc

Issue 153273002: Include the language (locale) info in the update ping (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Comments, Unittest Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/updater/manifest_fetch_data.cc ('k') | chrome/browser/extensions/webstore_installer_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/webstore_installer.cc

diff --git a/chrome/browser/extensions/webstore_installer.cc b/chrome/browser/extensions/webstore_installer.cc

index 2b6813673d0fb539a32f0af2c967ab20d246cab1..f9caccad4e009a2ddf73fafdcc52cf18ca92a8eb 100644

--- a/chrome/browser/extensions/webstore_installer.cc

+++ b/chrome/browser/extensions/webstore_installer.cc

@@ -19,7 +19,6 @@

#include "base/strings/string_util.h"

#include "base/strings/stringprintf.h"

#include "base/strings/utf_string_conversions.h"

-#include "chrome/browser/browser_process.h"

#include "chrome/browser/chrome_notification_types.h"

#include "chrome/browser/download/download_crx_util.h"

#include "chrome/browser/download/download_prefs.h"

@@ -28,13 +27,13 @@

#include "chrome/browser/extensions/install_tracker.h"

#include "chrome/browser/extensions/install_tracker_factory.h"

#include "chrome/browser/extensions/install_verifier.h"

+#include "chrome/browser/omaha_query_params/omaha_query_params.h"

#include "chrome/browser/profiles/profile.h"

#include "chrome/browser/ui/browser_list.h"

#include "chrome/browser/ui/tabs/tab_strip_model.h"

#include "chrome/common/chrome_paths.h"

#include "chrome/common/chrome_switches.h"

#include "chrome/common/extensions/extension_constants.h"

-#include "chrome/common/omaha_query_params/omaha_query_params.h"

#include "content/public/browser/browser_thread.h"

#include "content/public/browser/download_manager.h"

#include "content/public/browser/download_save_info.h"

@@ -168,7 +167,6 @@ GURL WebstoreInstaller::GetWebstoreInstallURL(

params.push_back("id=" + extension_id);

if (!install_source.empty())

params.push_back("installsource=" + install_source);

- params.push_back("lang=" + g_browser_process->GetApplicationLocale());

params.push_back("uc");

std::string url_string = extension_urls::GetWebstoreUpdateUrl().spec();