Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(308)

Side by Side Diff: chrome/browser/extensions/webstore_installer_unittest.cc

Issue 153273002: Include the language (locale) info in the update ping (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Comments, Unittest Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <string> 5 #include <string>
6 6
7 #include "base/strings/stringprintf.h" 7 #include "base/strings/stringprintf.h"
8 #include "chrome/browser/extensions/webstore_installer.h" 8 #include "chrome/browser/extensions/webstore_installer.h"
9 #include "chrome/common/omaha_query_params/omaha_query_params.h" 9 #include "chrome/browser/omaha_query_params/omaha_query_params.h"
10 #include "extensions/common/id_util.h" 10 #include "extensions/common/id_util.h"
11 #include "net/base/escape.h" 11 #include "net/base/escape.h"
12 #include "testing/gtest/include/gtest/gtest.h" 12 #include "testing/gtest/include/gtest/gtest.h"
13 13
14 using base::StringPrintf; 14 using base::StringPrintf;
15 using chrome::OmahaQueryParams; 15 using chrome::OmahaQueryParams;
16 16
17 namespace extensions { 17 namespace extensions {
18 18
19 // Returns true if |target| is found in |source|. 19 // Returns true if |target| is found in |source|.
20 bool Contains(const std::string& source, const std::string& target) { 20 bool Contains(const std::string& source, const std::string& target) {
21 return source.find(target) != std::string::npos; 21 return source.find(target) != std::string::npos;
22 } 22 }
23 23
24 TEST(WebstoreInstallerTest, PlatformParams) { 24 TEST(WebstoreInstallerTest, PlatformParams) {
25 std::string id = extensions::id_util::GenerateId("some random string"); 25 std::string id = extensions::id_util::GenerateId("some random string");
26 std::string source = "inline"; 26 std::string source = "inline";
27 GURL url = WebstoreInstaller::GetWebstoreInstallURL(id, 27 GURL url = WebstoreInstaller::GetWebstoreInstallURL(id,
28 WebstoreInstaller::INSTALL_SOURCE_INLINE); 28 WebstoreInstaller::INSTALL_SOURCE_INLINE);
29 std::string query = url.query(); 29 std::string query = url.query();
30 EXPECT_TRUE(Contains(query,StringPrintf("os=%s", OmahaQueryParams::getOS()))); 30 EXPECT_TRUE(
31 EXPECT_TRUE(Contains(query,StringPrintf("arch=%s", 31 Contains(query, StringPrintf("os=%s", OmahaQueryParams::GetOS())));
32 OmahaQueryParams::getArch()))); 32 EXPECT_TRUE(
33 EXPECT_TRUE(Contains(query,StringPrintf("nacl_arch=%s", 33 Contains(query, StringPrintf("arch=%s", OmahaQueryParams::GetArch())));
34 OmahaQueryParams::getNaclArch()))); 34 EXPECT_TRUE(Contains(
35 EXPECT_TRUE(Contains(query,net::EscapeQueryParamValue( 35 query, StringPrintf("nacl_arch=%s", OmahaQueryParams::GetNaclArch())));
36 StringPrintf("installsource=%s", source.c_str()), 36 EXPECT_TRUE(
37 true))); 37 Contains(query,
38 net::EscapeQueryParamValue(
39 StringPrintf("installsource=%s", source.c_str()), true)));
40 EXPECT_TRUE(
41 Contains(query, StringPrintf("lang=%s", OmahaQueryParams::GetLang())));
38 } 42 }
39 43
40 } // namespace extensions 44 } // namespace extensions
OLDNEW
« no previous file with comments | « chrome/browser/extensions/webstore_installer.cc ('k') | chrome/browser/omaha_query_params/OWNERS » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698